Re: [Linux-ATM-General] [RFC][PATCH 0/2] atm: br2682: Improve encapsulation checks and headroom allocation

[chas w. - C. <ch...@cm...>]

On Mon, 08 Aug 2011 00:05:24 +0200
Pascal Hambourg <pa...@pl...> wrote:

> Also it appears that eth_type_trans(), which is called in the bridged receive
> path in br2684_push(), calls skb_pull(skb, ETH_HLEN). Shouldn't the packet
> length be checked before calling eth_type_trans() ?

probably.  i dont see any reason it shouldnt be checked.

> Similarly, shouldn't the packet length be checked in the VC-MUX routed path
> before reading the IP header version ?

yes, that seems reasonable.