Re: [Linux-ATM-General] br2684 : sent packets truncated in VC routed mode

[Pascal H. <pa...@pl...>]

chas williams - CONTRACTOR wrote :
> Francois Romieu <ro...@fr...> wrote:
> 
>> A short explanation of the skb_pull(skb, ETH_HLEN) for e_vc/p_routed in
>> br2684_xmit_vcc would be welcome.
>>
>> I do not see how there can be ETH_HLEN excess bytes in this direction.
> 
> yeah, i think this skb_pull() is wrong.  when a routed interface is
> setup, it shouldnt be prepending ethernet headers on the outgoing
> packets so there shouldnt be any need to remove an ethernet header.

Besides, there is no such operation in the code for LLC routed encapsulation.

> anyone willing/capable of testing a patch?

As I wrote in my initial message, I commented out skb_pull(skb, ETH_HLEN)
and now PDUs transmitted on a virtual interface look correct when printed
by atmtcp. I am planning to do a real test on an ADSL line with VC-MUX
routed encapsulation tomorrow.