Re: [Linux-ATM-General] br2684 : sent packets truncated in VC routed mode

[chas w. - C. <ch...@cm...>]

On Thu, 28 Jul 2011 21:10:38 +0200
Francois Romieu <ro...@fr...> wrote:

> Eric Kinzie (contractor) <ek...@cm...> :
> [...]
> > Changing the -p option to "1" will put an ethernet header in each pdu.
> > See rfc 1483 section 4.1 for a description of the "routed" configuration
> > (-p 0).
> 
> A short explanation of the skb_pull(skb, ETH_HLEN) for e_vc/p_routed in
> br2684_xmit_vcc would be welcome.
> 
> I do not see how there can be ETH_HLEN excess bytes in this direction.
> 

yeah, i think this skb_pull() is wrong.  when a routed interface is
setup, it shouldnt be prepending ethernet headers on the outgoing
packets so there shouldnt be any need to remove an ethernet header.

anyone willing/capable of testing a patch?