From: Philip P. <phi...@re...> - 2011-03-21 22:18:09
|
On 3/21/11 2:08 PM, Chas Williams (CONTRACTOR) wrote: > In message<4D8...@re...>,Philip Prindeville writes: >> Yeah, it turns out there was... the transition from UNKNOWN to LOST. >> >> Should we (a) initialize the driver state as LOST, and (b) not release all VCs when the carrier flaps? >> >> I'm thinking that now that we have correct carrier state indication, maybe user-space apps should pay attention to that instead? > i dont think that pvc's should give a damn about carrier state. > they certainly shouldnt close because carrier state flapped. svc's are > a different story -- tearing down svc's on carrier state change does > sort of make sense. this should already happen though since atmsigd is > smart enough to make this happen. > > SIG_UNKNOWN and SIG_FOUND should mean the same thing. the carrier > state cant be followed or is found so the application should go ahead > with its business. if the solos pci driver can track state perhaps it > should init the signal to SIG_LOST. UKNOWN was really meant (i gather) > to indicate that the carrier isnt tracked by the driver. > > if applications are curious about the line state, yes they should be > asking the driver about the line state not hoping that the pvc gets > torn down and rebuilt. Can you commit the debug skb_pull() fix and I'll work up a fix for the flapping/initialization issue? Thanks, -Philip |