Re: [Linux-ATM-General] [PATCH v2 1/1] solos-pci: Fix regression introduced by newest firmware

[MIke W. <we...@cs...>]

I'll be the first to admit that (1) I'm a grouchy old guy who (2) first 
programmed on an IBM 1620 and then on a 360  Model 30 with 32K ram.  But 
why oh why do we need to use 9 byte string constants with per character 
compare to decide if the device is up or not :-(




Philip Prindeville wrote:
> The newest FPGA firmware on the Solos processors correctly signals carrier transitions, bitrate, etc.
>
> The driver previously ignored these messages, and the physical state was always ATM_PHY_SIG_UNKNOWN.
>
> Now that the board reports its state, we expose a bug whereby the transition from UNKNOWN to LOST causes us to release all VC's.
>
> We don't delete any VC's, but instead just send an indication of carrier change.
>
> Signed-off-by: Philip A Prindeville <ph...@re...>
> ---
>
> --- a/drivers/atm/solos-pci.c	2011-03-20 15:27:40.000000000 -0600
> +++ b/drivers/atm/solos-pci.c	2011-03-20 16:32:11.000000000 -0600
> @@ -382,8 +382,10 @@ static int process_status(struct solos_c
>
>   	/* Anything but 'Showtime' is down */
>   	if (strcmp(state_str, "Showtime")) {
>   		atm_dev_signal_change(card->atmdev[port], ATM_PHY_SIG_LOST);
> +#if 0
>   		atm_dev_release_vccs(card->atmdev[port]);
> +#endif
>   		dev_info(&card->dev->dev, "Port %d: %s\n", port, state_str);
> 		return 0;
> 	}
>
>
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Linux-atm-general mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linux-atm-general
>
>
>