From: Karl H. <ka...@hi...> - 2010-09-22 06:54:23
|
On 09/22/10 07:21, Philip Prindeville wrote: > On 9/21/10 2:24 AM, Karl Hiramoto wrote: >> On 09/21/10 05:49, Philip Prindeville wrote: >>> Let me know if you need me to test new patches. >>> >> >> Attached is another patch that replaces the previous patch. >> >> Thanks. > > + read_lock_irqsave(&devs_lock, flags); > + list_for_each(lh,&pppoa_vccs) { > + pvcc = list_entry(lh, struct pppoatm_vcc, list_head); > > Do we need here: > > if (!pvcc) > continue; > > or should this never be empty? Should never be empty. I attached another version of the patch. Thanks, Karl |