Re: [Linux-ATM-General] Fwd: Re: [PATCH] pppoatm carrier status

[Philip P. <phi...@re...>]

  On 9/21/10 2:24 AM, Karl Hiramoto wrote:
> On 09/21/10 05:49, Philip Prindeville wrote:
>>   Let me know if you need me to test new patches.
>>
>
> Attached is another patch that replaces the previous patch.
>
> Thanks.

+	read_lock_irqsave(&devs_lock, flags);
+	list_for_each(lh,&pppoa_vccs) {
+		pvcc = list_entry(lh, struct pppoatm_vcc, list_head);

Do we need here:

if (!pvcc)
	continue;

or should this never be empty?


+		atm_vcc = pvcc->atmvcc;
+		if (atm_vcc&&  atm_vcc->dev == atm_dev) {
+
+			if (atm_vcc->dev->signal == ATM_PHY_SIG_LOST)
+					ppp_channel_carrier_off(&pvcc->chan);
+				else
+					ppp_channel_carrier_on(&pvcc->chan);
+		}
+	}
+	read_unlock_irqrestore(&devs_lock, flags);