Re: [Linux-ATM-General] [PATCH] pppoatm carrier status

[Philip P. <phi...@re...>]

  On 9/15/10 1:57 AM, Karl Hiramoto wrote:
> Philip,
>
> I attached a patch you can try for pppoatm, I have no way to test this
> myself.  It compiles OK I'm not sure if the changes in
> drivers/net/ppp_generic.c are OK.
>
> If your going to try and use 2.6.27 you'll have to backport all the
> other patches I sent earlier.
>
>
>
> --
> Karl

Giving it a try now.  The first patch set (v5) dropped in with only two modifications.

The patch you sent only needed one modification (so far... haven't run it yet).

Btw, in the original patches, you had:

+               list_for_each_entry(brvcc,&BRPRIV(net_dev)->brvccs, brvccs) {
+                       atm_vcc = brvcc->atmvcc;
+                       if (atm_vcc&&  brvcc->atmvcc->dev == atm_dev) {

This should be:

   if (atm_vcc&&  atm_vcc->atmvcc->dev == atm_dev) {

just for consistency (or if you've compiled this with optimization off, and breakpoint and then modify the value of atm_vcc ...



+
+                               if (atm_vcc->dev->signal == ATM_PHY_SIG_LOST)
+                                       netif_carrier_off(net_dev);
+                               else
+                                       netif_carrier_on(net_dev);