linux-atm-general

[Linux-ATM-General] [PATCH 1/1] Use VPI.VCI notation consistently in solos-pci driver

[Philip P. <phi...@re...>]

Use VPI.VCI notation consistently.

Signed-of-by: Philip Prindeville<ph...@re...>
---

--- a/drivers/atm/solos-pci-0.11/solos-pci.c	2010-12-24 01:07:09.000000000 -0700
+++ b/drivers/atm/solos-pci-0.11/solos-pci.c	2010-12-24 14:18:45.000000000 -0700
@@ -734,8 +734,8 @@ void solos_bh(unsigned long card_arg)
  					       le16_to_cpu(header->vci));
  				if (!vcc) {
  					if (net_ratelimit())
-						dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
-							 le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
+						dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
+							 le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
  							 port);
  					continue;
  				}

Re: [Linux-ATM-General] [PATCH 1/1] Use VPI.VCI notation consistently in solos-pci driver

[Philip P. <phi...@re...>]

Hang on, I just looked upstream in git.kernel.org and realized that there are a lot of fixes there that aren't in the openadsl tree...

It would be nice to update openadsl and release a solos-pci driver 0.12 with these updates.



On 12/26/10 11:09 AM, Philip Prindeville wrote:
> Use VPI.VCI notation consistently.
>
> Signed-of-by: Philip Prindeville<ph...@re...>
> ---
>
> --- a/drivers/atm/solos-pci-0.11/solos-pci.c	2010-12-24 01:07:09.000000000 -0700
> +++ b/drivers/atm/solos-pci-0.11/solos-pci.c	2010-12-24 14:18:45.000000000 -0700
> @@ -734,8 +734,8 @@ void solos_bh(unsigned long card_arg)
>    					       le16_to_cpu(header->vci));
>    				if (!vcc) {
>    					if (net_ratelimit())
> -						dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
> -							 le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
> +						dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
> +							 le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
>    							 port);
>    					continue;
>    				}
>

Re: [Linux-ATM-General] [PATCH 1/1] Use VPI.VCI notation consistently in solos-pci driver

[Philip P. <phi...@re...>]

Is anyone else still building solos drivers from sourceforge, or is everyone expected to be using the ones in-tree at this point?

Because a few projects out there are still building from 2.6.27.x and want to build the drivers from what's on sourceforge, but if that's no longer maintained then they might have to improvise.

Maybe it's time to yank the tarball on sourceforge as a way of telling people to use the in-tree sources, and if that's not an option, to light a fire under them to bump their kernel versions...


On 12/26/10 12:02 PM, Philip Prindeville wrote:
> Hang on, I just looked upstream in git.kernel.org and realized that there are a lot of fixes there that aren't in the openadsl tree...
>
> It would be nice to update openadsl and release a solos-pci driver 0.12 with these updates.
>

Re: [Linux-ATM-General] [PATCH 1/1] Use VPI.VCI notation consistently in solos-pci driver

[Philip P. <phi...@re...>]

Nix.

My sed script mangled the paths, and after doing a quick check on git.kernel.org I see this one has already been applied... it just hasn't made it back downstream into the openadsl project on SourceForge.


On 12/26/10 11:09 AM, Philip Prindeville wrote:
> Use VPI.VCI notation consistently.
>
> Signed-of-by: Philip Prindeville<ph...@re...>
> ---
>
> --- a/drivers/atm/solos-pci-0.11/solos-pci.c    2010-12-24 01:07:09.000000000 -0700
> +++ b/drivers/atm/solos-pci-0.11/solos-pci.c    2010-12-24 14:18:45.000000000 -0700
> @@ -734,8 +734,8 @@ void solos_bh(unsigned long card_arg)
>                             le16_to_cpu(header->vci));
>                  if (!vcc) {
>                      if (net_ratelimit())
> -                        dev_warn(&card->dev->dev, "Received packet for unknown VCI.VPI %d.%d on port %d\n",
> -                             le16_to_cpu(header->vci), le16_to_cpu(header->vpi),
> +                        dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n",
> +                             le16_to_cpu(header->vpi), le16_to_cpu(header->vci),
>                               port);
>                      continue;
>                  }
>
>