#25 asn_bits.c:348: bad compare ?

[dcb]

asn_bits.c:348:64: warning: self-comparison always evaluates to true [-Wtautological-compare]

Source code is

return ( (b1->bitLen == b2->bitLen) &&
         (memcmp(b1->bits, b2->bits, octetsLessOne) == 0) &&
         (( b1->bits[octetsLessOne] & (0xFF << octetBits)) ==
          ( b1->bits[octetsLessOne] & (0xFF << octetBits))));

Maybe better code:

return ( (b1->bitLen == b2->bitLen) &&
         (memcmp(b1->bits, b2->bits, octetsLessOne) == 0) &&
         (( b1->bits[octetsLessOne] & (0xFF << octetBits)) ==
          ( b2->bits[octetsLessOne] & (0xFF << octetBits))));