#24 bad macro defn CHECK() in sapequal.c

[Nick Briggs]

Seems pretty dead around here... but just in case: Compiling OpenWRT, which included linux-atm-2.5.2, generated the following warning -- a result of missing parentheses in the macro definition for CHECK:

sapequal.c: In function 'match_blli':
sapequal.c:65:42: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
CHECK(l2.itu.window,a.l2.itu.window > b.l2.itu.window);
^
sapequal.c:46:10: note: in definition of macro 'CHECK'
if (!CONSTRAINT) return 0; \ ^~~~~~~~~~
sapequal.c:46:9: note: add parentheses around left hand side expression to silence this warning
if (!CONSTRAINT) return 0; \ ^~~~~~~~~~~~~~~~~~~~~~~~
if (res) res->FIELD = a.FIELD < b.FIELD ? a.FIELD : b.FIELD; \ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
}
~

[Nick Briggs]

Obviously, the fix is
if (!(CONSTRAINT)) return 0;

[chas williams]

Some of us are still here. I will look into fixing this. Thanks for the bug report!