#26 minor refactor in windows.cc, fix build issue

[Steven R. Loomis]

on buster (Debian 10)

g++ -DHAVE_CONFIG_H -I. -I..     -g -O2 -MT windows.o -MD -MP -MF .deps/windows.Tpo -c -o windows.o windows.cc
In file included from windows.h:20,
                 from windows.cc:16:
windows.cc: In member function ‘void Window::outch(char, int)’:
windows.cc:430:67: warning: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
                   if (fg > 7) atr = COLOR_PAIR(alloc_pair(f - 8, b)) | A_BOLD;
                                                                   ^
In file included from windows.h:20,
                 from windows.cc:16:
/usr/include/curses.h:931:28: note: candidate 1: ‘int alloc_pair(int, int)’
 extern NCURSES_EXPORT(int) alloc_pair (int, int);
                            ^~~~~~~~~~
windows.cc:45:5: note: candidate 2: ‘int alloc_pair(short int, short int)’
 int alloc_pair(short f, short b)
     ^~~~~~~~~~

I think there's now an alloc_pair that is part of curses.

[Martin Cooper]

This was fixed 14 months ago (2019-02-11) on the develop branch. See:
https://sourceforge.net/p/linpac/linpac/ci/2c78bb53df119e82511a957a1fe8f46e2aa1ba8c/

[Steven R. Loomis]

OK., thanks Please close this then.

[David Ranch]

Already fixed in the develop branch