#64 recording time is brittle

[Anonymous]

Originally created by: bill-auger
Originally owned by: bill-auger

parsing recording time is brittle - strictly dependent on the values in NETWORK::KNOWN_HOSTS , NETWORK::KNOWN_BOTS , and CLIENT::BOT_CHANNELIDX

although the bot userIdx will almost always be 0 - still KNOWN_BOTS and BOT_CHANNELIDX are poor implementations - in order for bot names to be canonical as such would require that the servers authenticated users which currently they do not - for now the there could be a hard-coded host<->bot association and userIdx could be made more robust

possible remedies:
* add LinJam::CurrentBotIdx and set in LinJam::HandleUserInfoChanged()
* re-implement KNOWN_BOTS as a dictionary

[Anonymous]

Originally posted by: bill-auger

1e940f1 was squashed into f3548d2

1e940f1 has full implementations of KNOWN_BOTS as both HashMap and XmlElement - the HashMap could not be made const so XmlElement will be favored

[Anonymous]

Originally posted by: bill-auger

closing for now - this is perhaps as robust as this feature will be with libninjam in its current form or unless all servers authenticate their capture bot - perhaps the best solution is actually to query bots via HTTP but the API is not yet known and is not yet clear if all bots implement the same API

[Anonymous]

Ticket changed by: bill-auger

• status: open --> closed