Menu

#62 demeter and visibility issues

closed
nobody
2015-03-17
2014-08-07
Anonymous
No

Originally created by: bill-auger
Originally owned by: bill-auger

  • LinJamConfig class has probably too many public methods - excepting the LinJam class probably a few static helpers would suffice - currently only the Login and License classes are preventing this
  • Login and License should be passed in <server> store</server>
  • Config.cpp and MainContent.cpp need LinJam.h only for ConfigDismissed() and ConfigPending() (via button listeners)
  • friendships and method visibilities could be reduced in other classes as well

Discussion

  • Anonymous

    Anonymous - 2015-03-16

    Originally posted by: bill-auger

    most recent commit 801956a was squashed into previous 8b7e5f4

    • re: Config.cpp and MainContent.cpp need LinJam.h ....
      in order to remove LinJam::configPending() and LinJam::configDismissed() methods and eliminate LinJam.h include in MainContent and Config - it is possible to move button listeners for setting state CONFIG_PENDING pending (MainContent) and dismiss (Config) into LinJamConfig - but this requires declaring LinJam and LinJamConfig as friend classes to MainContent and Config to manage the buttons - so it was decided to leave this as is
     
  • Anonymous

    Anonymous - 2015-03-17

    Ticket changed by: bill-auger

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2015-03-17

    Originally posted by: bill-auger

    done

    most recent commit b00996d was squashed into previous 801956a - the commit message of b00996d represents the 'linux-demeter' branch agregate

     

Anonymous
Anonymous

Add attachments
Cancel