Menu

#33 prune unneeded LinJamConfig instance vars

closed
nobody
2015-03-12
2014-06-21
Anonymous
No

Originally created by: bill-auger
Originally owned by: bill-auger

most of the LinJamConfig members are unused or redundant - they are no longer needed as Value holders as we are now using ValueTree::Listener instead of Value::Listener - for example all Channel objects hold a handle to their ValueTree making the master Values superfluous

the only data that does not yet conform to this scheme are remote channels - remote configs are currently added to the root storage node for simplicity (e.g. Trace::SanitizeConfig() is not prepared to handle nested nodes) but they should eventually be added to a <remote-channels> storage node

it would be more sensible and descriptive to categorize all trees keeping the number of root leaves (and instance vars) to a minimum especially now that there is a single listener for all changes

Discussion

  • Anonymous

    Anonymous - 2014-07-29

    Originally posted by: bill-auger

    most Value holder instance vars have been removed excepting those pertaining to login (<server> node) but these could be merged into <servers> node</servers></server>

    [433bc4]

    still todo <remote-channels> node

     
  • Anonymous

    Anonymous - 2015-03-12

    Ticket changed by: bill-auger

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2015-03-12

    Originally posted by: bill-auger

    done - remotes are now a distinct node

    0c6c236

     

Anonymous
Anonymous

Add attachments
Cancel