Re: [LineControl-development] linesrv doesn't close standard file descriptors

[S. F. <sf...@gm...>]

Hi there,

> > I have committed a modified and commented version of the patch to CVS
> > HEAD in linesrv-2.1. It works for me. I have not touched linesrv-3, as
> > the code in question is triplicated (well, duplicated twice, so code is
> > in 3 places) and needs to be cleaned up before thinking about doing
> > "proper" daemonizing.

Well... in linesrv-3 we have it only once, right? (in bool CUseful::Detach(),
useful.cc)

Thanks for applying the patch, Roe. Please have a look at the current
cvs HEAD version. I introduced a HAVE_DAEMON conditional. Sorry,
right now I don't have the time to test it. So please wait until I do
it or do it yourself and report.

> Is linesrv-3 usable yet? I looked at the age of the files and 
> wondered if it was dead. I wanted to try it before submitting the 
> patch, but I wasn't even sure how to build it. Must one invoke 
> automake or autoconf to get a configure script?

No, linesrv-3 is not dead. I'm just damned slow finishing that
new version. The code which executes the dial/hangup scripts and
monitors their action has to be written yet. The rest is more or
less complete though it still needs debugging. Probably you better
wait until I release linesrv-3.0.0-t01.
If someone would like to put his hands on that code before I finished
the basic functionality please write a mail.

> > It seems that the Really Right Thing to do will be to call the daemon(3)
> > syscall on systems where it is available, instead of doing all the
> > daemonizing ourselves (and possibly screwing up).
> 
> Yes, it looks like daemon() is the ticket. I wasn't even aware of 
> it until I read your message. I guess it should come as no 
> surprise that such a common activity would be made into a library 
> function.

See new configure.in / acconfig.h / linesrv.c

Greetings & Thanks

Stefan Fuchs