Re: [Linecontrol-development] Number of clients online

[S. F. <lin...@gm...>]

Hi there,

> I got a request from a user that as far as I can tell needs changes to the 
> protocol and the server. He wants to be able to see when any client becomes 
> online on the line he uses without having to request it through server 
> status.

Currently we have the CMD3_STATREQ for which the server responds with a
CMD3_STATUS (server/proc_lcp3.c, lines 205 to 217). This commands includes
the
(lcp3.h, line 169)
struct t_lcp3_info_status { // extended server status
    unsigned int clients;	// 2	+0	number of registered clients
    unsigned int online;	// 2	+2	num of cl. that are online
				// on any line (summarized)
};

which returns the _total_ number of clients registered / online (on any line).
The clients wlc (any version), lcc, xlc and xlcm don't use this information so
it's possible to just change that. Regarding klcc and jlc I suggest to do the
same (or at least tell me, that you need this value as it is now ;).

> Now, I think I have requested something like this before and you
> said it wouldn't be possible with current architecture?

It's possible that I said this.
To do it, one would have to:
- change proc_lcp3.c, lines 205-217 to only count the line with line->id == pack->line_id
- cd server ; grep -n 'online++' ; grep -n 'online--';
  --> prepare & send a CMD3_STATUS for the given line...

Currently I don't feel like doing this (I don't like the linesrv 2.1 source anymore, working
on 3.0 ;), so if someone needs it he can do it and send me a patch. I'm sorry, but I don't
give this feature high prio as there are other much more important things to do (e.g. auto
enumeration of the ppp devices, get user authentication for linesrv 3 working (mysql,
system crypt/md5, pam, ip, none), ...).

> But I thought that asking wouldn't hurt anyone.. :)

Ouch... no, seriously, of course you may ask anything. The worst you
can get is no answer. ;)

--> If there's anyone who would like to take over linesrv 2.1... just tell me. I'm busy
enough with linesrv 3.

Greetings

Stefan Fuchs