Re: [Line6linux-devel] [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

[Stefan H. <ste...@gm...>]

On Thu, Nov 22, 2012 at 8:58 PM, Greg Kroah-Hartman
<gr...@li...> wrote:
> On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote:
>> Markus and I have discussed the MIDI processing that currently happens in the
>> line6 driver.  This stuff really belongs in userspace where a library or
>> utility can use ALSA MIDI APIs to control the device.  Moving MIDI processing
>> to userspace has several benefits:
>>
>> 1. The driver only handles PCM and MIDI I/O.  This means less kernel code.
>>
>> 2. A large number of sysfs attributes can be removed.  These attributes exposed
>>    MIDI state and driver code was necessary to sync and manage this state.
>>
>> 3. It's easier for userspace to control the device, try out new MIDI commands,
>>    etc when the driver acts as a dumb transport.
>>
>> This patch series removes the sysfs attributes and then removes the state
>> behind those attributes.  I have tried to make small incremental changes that
>> can be reviewed easily.
>
> Very nice, I'll queue these up on Monday, very good work, thanks so much
> for doing this.

Thanks!  I hope Markus has a chance to review and/or test these
changes first - he knows generally what I'm up too but should have the
final word on details.

Stefan