Re: [Line6linux-devel] line6 out of staging

[Stefan H. <ste...@gm...>]

On Thu, Nov 22, 2012 at 10:49 AM, Stefan Hajnoczi <ste...@gm...> wrote:
> On Thu, Nov 22, 2012 at 8:57 AM, Laurent Navet <lau...@ya...> wrote:
>> Let me know if there's some easy and boring tasks you don't want to waste
>> time on. Like fix CodingStyle or so.
>> I'm not a kernel guru but can fix minor issues.
>
> I will send out a patch series this weekend that drops a lot of code
> (that functionality moves to userspace).  This means coding style
> cleanups right now might be wasted on code that gets deleted.
>
> Once I've sent the series I'll also send an email to line6linux-devel
> with the todo list that remains.  Maybe you'll find something that you
> want to tackle.

I had some time to prepare the patch series and have sent them out
earlier than expected.

If you'd like to help clean up the staging driver, I suggest starting
with my line6-drop-sysfs-attrs branch (saves you from applying the
patch emails yourself):
https://github.com/stefanha/linux/tree/line6-drop-sysfs-attrs

By using the patches I just sent out as a starting point you avoid
cleaning up code that is going to be removed anyway.

Here are the remaining checkpatch.pl warnings, we should eventually
address them all:

WARNING: line over 80 characters
#64: FILE: staging/line6/driver.c:61:
+ { LINE6_BIT_BASSPODXT,     "BassPODxt",     "BassPODxt",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#65: FILE: staging/line6/driver.c:62:
+ { LINE6_BIT_BASSPODXTLIVE, "BassPODxtLive", "BassPODxt Live",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#66: FILE: staging/line6/driver.c:63:
+ { LINE6_BIT_BASSPODXTPRO,  "BassPODxtPro",  "BassPODxt Pro",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#67: FILE: staging/line6/driver.c:64:
+ { LINE6_BIT_GUITARPORT,    "GuitarPort",    "GuitarPort",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#68: FILE: staging/line6/driver.c:65:
+ { LINE6_BIT_POCKETPOD,     "PocketPOD",     "Pocket POD",
LINE6_BIT_CONTROL           },

WARNING: line over 80 characters
#69: FILE: staging/line6/driver.c:66:
+ { LINE6_BIT_PODHD300,      "PODHD300",      "POD HD300",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#70: FILE: staging/line6/driver.c:67:
+ { LINE6_BIT_PODHD500,      "PODHD500",      "POD HD500",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#71: FILE: staging/line6/driver.c:68:
+ { LINE6_BIT_PODSTUDIO_GX,  "PODStudioGX",   "POD Studio GX",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#72: FILE: staging/line6/driver.c:69:
+ { LINE6_BIT_PODSTUDIO_UX1, "PODStudioUX1",  "POD Studio UX1",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#73: FILE: staging/line6/driver.c:70:
+ { LINE6_BIT_PODSTUDIO_UX2, "PODStudioUX2",  "POD Studio UX2",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#74: FILE: staging/line6/driver.c:71:
+ { LINE6_BIT_PODX3,         "PODX3",         "POD X3",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#75: FILE: staging/line6/driver.c:72:
+ { LINE6_BIT_PODX3LIVE,     "PODX3Live",     "POD X3 Live",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#76: FILE: staging/line6/driver.c:73:
+ { LINE6_BIT_PODXT,         "PODxt",         "PODxt",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#77: FILE: staging/line6/driver.c:74:
+ { LINE6_BIT_PODXTLIVE,     "PODxtLive",     "PODxt Live",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#78: FILE: staging/line6/driver.c:75:
+ { LINE6_BIT_PODXTPRO,      "PODxtPro",      "PODxt Pro",
LINE6_BIT_CONTROL_PCM_HWMON },

WARNING: line over 80 characters
#79: FILE: staging/line6/driver.c:76:
+ { LINE6_BIT_TONEPORT_GX,   "TonePortGX",    "TonePort GX",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#80: FILE: staging/line6/driver.c:77:
+ { LINE6_BIT_TONEPORT_UX1,  "TonePortUX1",   "TonePort UX1",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#81: FILE: staging/line6/driver.c:78:
+ { LINE6_BIT_TONEPORT_UX2,  "TonePortUX2",   "TonePort UX2",
LINE6_BIT_PCM               },

WARNING: line over 80 characters
#82: FILE: staging/line6/driver.c:79:
+ { LINE6_BIT_VARIAX,        "Variax",        "Variax Workbench",
LINE6_BIT_CONTROL           },

WARNING: line over 80 characters
#218: FILE: staging/line6/driver.c:215:
+  line6->ep_control_write),

WARNING: line over 80 characters
#577: FILE: staging/line6/driver.c:574:
+ /* Wait for data length. We'll get a couple of 0xff until length arrives. */

WARNING: line over 80 characters
#26: FILE: staging/line6/driver.h:23:
+#if defined(CONFIG_LINE6_USB_DUMP_CTRL) ||
defined(CONFIG_LINE6_USB_DUMP_MIDI) ||
defined(CONFIG_LINE6_USB_DUMP_PCM)

WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then
pr_err(...  to printk(KERN_ERR ...
#59: FILE: staging/line6/driver.h:56:
+ printk(KERN_ERR "line6usb driver bug: missing case in %s:%d\n", \

WARNING: simple_strtoul is obsolete, use kstrtoul instead
#87: FILE: staging/line6/pcm.c:84:
+ dev2pcm(dev)->impulse_period = simple_strtoul(buf, NULL, 10);

ERROR: switch and case should be at the same indent
#426: FILE: staging/line6/pcm.c:423:
+ switch (line6->product) {
[...]
+   case LINE6_DEVID_TONEPORT_UX2:
+   case LINE6_DEVID_PODSTUDIO_UX2:

WARNING: line over 80 characters
#248: FILE: staging/line6/playback.c:245:
+ if (line6pcm->flags & LINE6_BIT_PCM_ALSA_CAPTURE_STREAM) {

WARNING: line over 80 characters
#254: FILE: staging/line6/playback.c:251:
+   urb_out->transfer_buffer_length);

WARNING: line over 80 characters
#40: FILE: staging/line6/pod.c:37:
+ /* POD_SYSEX_DUMPMEM2  = 0x76 */   /* dumps entire internal memory
of PODxt Pro */

WARNING: line over 80 characters
#162: FILE: staging/line6/pod.c:159:
+ if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) == 0) {

ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: staging/line6/usbdefs.h:42:
+#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x