Re: [Line6linux-devel] Getting line6usb past staging

[L. A. G. <agi...@sy...>]

El 07/11/2012 9:03, Stefan Hajnoczi escribió:
> On Tue, Nov 6, 2012 at 10:10 PM, Markus Grabner <gr...@ic...> wrote:
>> Am Samstag, 3. November 2012, 00:06:56 schrieb Stefan Hajnoczi:
 >>
>> Since I'm quite busy at the moment, it's absoutely fine for me if you make the
>> request. I reviewed and applied your latest changes to my working copy and
>> didn't notice any problem. As far as stability is concerned, I think the
>> driver is ready to enter the kernel main line. I can't contribute much to a
>> cleanup, though, since I'm not too familiar with kernel policies (everything
>> which compiles & works is fine for me :-).

Well, usually the people that know about the particular subsystem (ALSA, 
USB, ...) will point on the right direction regarding APIs or policies.

>>
>> Since there are already several branches in the subversion repository
>> https://line6linux.svn.sourceforge.net/svnroot/line6linux/driver, I suggest to
>> create a cleanup branch there if necessary before moving the driver to the
>> main line (I am aware that many people prefer git, but using too many
>> repositories for the same piece of software is getting tedious). What do you
>> think?

It's OK for me, but I would suggest to use git, since it will be easier 
for us to contribute, and easier to interact with the kernel guys.

Also, since the kernel is using git, it would be way easier to merge 
changes if we use the git repository.

And last, if someday we make into mainline, no separate repo will be 
useful anymore. The "main" line6usb code *will be* part of the kernel. 
And the maintenance and developement will be easier than havin an 
off-tree branch.

I have experience using git in case you need help (I think that Stefan 
too), but if you decide to keep working on SVN, I'll respect that.

>
> Is there any code in svn which needs to get into linux.git?
>
> Once we're happy with Greg KH's drivers/staging/line6 I think the process is:
>
> 1. Ask ALSA maintainers and Greg KH to review drivers/staging/line6.
> 2. Implement any requested cleanups and go back to 1.
> 3. Success!
>
> I don't think we need a repository for this.  The code review happens
> on the lkml, ALSA, and/or staging mailing list.  The patch series gets
> sent to those mailing lists.

Right, but setting up a repository (or just using one of linux-next, or 
Linus' tree or whatever) will ease the developement for us, I think, 
instead of trading with patches here and there.

Anyway, Stefan, what is your public repo address?

>
> When I send cleaned up patches, you and anyone else will be able to
> comment on them.
>
> Does this sound okay?

Yes. So, please, as the LKML is a quite high volume list, would you mind 
sending patches to this list as well, or just drop some notice pointing 
to the LKML messages?

Thank you!