Re: [Line6linux-devel] Getting line6usb past staging

[Markus G. <gr...@ic...>]

Am Samstag, 3. November 2012, 00:06:56 schrieb Stefan Hajnoczi:
> On Fri, Nov 2, 2012 at 9:02 PM, "L. Alberto Giménez"
> 
> <agi...@sy...> wrote:
> > El 02/11/2012 8:02, Stefan Hajnoczi escribió:
> >> Ping?
> > 
> > Hi Stefan,
> > 
> > I'm interested in helping with the driver code (or user-space
> > applications or wharever).
> > 
> > Unfortunately, right now my Linux box is dead and I'm waiting for a
> > motherboard/CPU replacement. When i get everytning running up, I will be
> > able to test/help.
> > 
> > By the way, what codebase are you currently working on? The official
> > kernel staging code? or do you use another personal repository?
> 
> I write small changes against linux.git.  For bigger changes I send
> patches against the subversion repo so Markus can review and send a
> pull request to Greg KH.
> 
> > We may set up a github repository for the cleanup process. I think that
> > a lot of changes will be needed since the current code is quite old and
> > a lot of interfaces and kernel policies may have changed.
> 
> The code builds against the latest linux.git so there is nothing
> terribly bitrotted.  I think the next step is to ask the ALSA
> maintainers to review the code.  It would be appropriate for Markus to
> make that request, since he's the maintainer.  This is why I'm pinging
> him - I don't want to bypass him by making that request myself.
Since I'm quite busy at the moment, it's absoutely fine for me if you make the 
request. I reviewed and applied your latest changes to my working copy and 
didn't notice any problem. As far as stability is concerned, I think the 
driver is ready to enter the kernel main line. I can't contribute much to a 
cleanup, though, since I'm not too familiar with kernel policies (everything 
which compiles & works is fine for me :-).

Since there are already several branches in the subversion repository 
https://line6linux.svn.sourceforge.net/svnroot/line6linux/driver, I suggest to 
create a cleanup branch there if necessary before moving the driver to the 
main line (I am aware that many people prefer git, but using too many 
repositories for the same piece of software is getting tedious). What do you 
think?

	Kind regards,
		Markus