line6linux-devel

[Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

[Laurent N. [Mali] <lau...@gm...>]

From: "Laurent Navet [Mali]" <lau...@gm...>

staging: line6: pcm.c
	call to obsolete simple_strtoul() function is replaced
        by kstrtoint() in pcm_set_impulse_period().
	Also check the return code.

Signed-off-by: Laurent Navet [Mali] <lau...@gm...>
---
 drivers/staging/line6/pcm.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index a0ce781..876ab89 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
@@ -81,7 +81,13 @@ static ssize_t pcm_set_impulse_period(struct device *dev,
 				      struct device_attribute *attr,
 				      const char *buf, size_t count)
 {
-	dev2pcm(dev)->impulse_period = simple_strtoul(buf, NULL, 10);
+        int value;
+        int rv;
+        rv = kstrtoint(buf, 10, &value);
+        if (rv < 0)
+		return rv;
+
+	dev2pcm(dev)->impulse_period = value;
 	return count;
 }
 
-- 
1.7.10.4

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

[Stefan H. <ste...@gm...>]

On Thu, Nov 29, 2012 at 9:03 PM, Laurent Navet [Mali]
<lau...@gm...> wrote:
> From: "Laurent Navet [Mali]" <lau...@gm...>
>
> staging: line6: pcm.c
>         call to obsolete simple_strtoul() function is replaced
>         by kstrtoint() in pcm_set_impulse_period().
>         Also check the return code.
>
> Signed-off-by: Laurent Navet [Mali] <lau...@gm...>
> ---
>  drivers/staging/line6/pcm.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <ste...@gm...>

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

[Dan C. <dan...@or...>]

On Thu, Nov 29, 2012 at 09:03:38PM +0100, Laurent Navet [Mali] wrote:
> From: "Laurent Navet [Mali]" <lau...@gm...>
> 
> staging: line6: pcm.c
> 	call to obsolete simple_strtoul() function is replaced
>         by kstrtoint() in pcm_set_impulse_period().
> 	Also check the return code.
> 
> Signed-off-by: Laurent Navet [Mali] <lau...@gm...>
> ---
>  drivers/staging/line6/pcm.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index a0ce781..876ab89 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -81,7 +81,13 @@ static ssize_t pcm_set_impulse_period(struct device *dev,
>  				      struct device_attribute *attr,
>  				      const char *buf, size_t count)
>  {
> -	dev2pcm(dev)->impulse_period = simple_strtoul(buf, NULL, 10);
> +        int value;
> +        int rv;

This uses spaces instead of tabs.  Run scripts/checkpatch.pl over
the patch before submitting.

Put a blank line here between the declarations and the code.

I see that you copied "rv" from the other places in the file and
generally matching the context is good, but in this case I think
"rv" is non-standard.  Normally we would use "ret" or "rc".

> +        rv = kstrtoint(buf, 10, &value);
> +        if (rv < 0)
> +		return rv;

Could you fix up those small details and resend?

regards,
dan carpenter