Thread: [limesurvey-developers] Admin theme view overrides
The leading Open Source survey tool
Brought to you by:
c_schmitz
From: Rystraum G. <rys...@gm...> - 2014-01-13 17:13:48
|
Hello, I was able to manage to enable other admin theme developers to be able to override existing admin views. It's available in my repo's fork, under the bootstrap branch. (https://github.com/rystraum/LimeSurvey/tree/bootstrap) Basically, it's a function that checks if the view file is existing under views/{theme_name}/{view_file_path}, and if it exists, it calls that. Otherwise, it defaults to views/admin/{view_file_path}. It's meant to replace $this->renderPartial calls in admin controllers. So, it's possible for gringegreen to override the views/admin/super/header by putting the overriding file in views/gringegreen/super/header.php. In the repo is a sample, very rough, work-in-progress theme that puts the admin backend onto a regular bootstrap layout. To switch views, you just have to configure the admin backend to use the bootstrap theme. A few problems that I've come across: 1. It's very difficult controlling the js and css packages because of the registerPackage calls within the controller methods. For now, I'm calling Yii::app()->getClientScript()->reset() so the overridden views has to include the stylesheets and scripts on their own. 2. AJAX-based/JS-based default views may not work as expected on overridden views because of (1). Comments are welcome. |
From: Sam M. <sa...@mo...> - 2014-01-13 17:53:30
|
Hi Rystraum, I haven't looked at your work specifically but I can tell you some general things though. - Yii already has built in theming support that we will be switching to in the future. - We do not want to replace the calls to render / renderPartial and other variants, instead we should switch to only using them. Cheers, Sam On Mon, Jan 13, 2014 at 6:13 PM, Rystraum Gamonez <rys...@gm...>wrote: > Hello, > > I was able to manage to enable other admin theme developers to be able to > override existing admin views. > > It's available in my repo's fork, under the bootstrap branch. > (https://github.com/rystraum/LimeSurvey/tree/bootstrap) > > Basically, it's a function that checks if the view file is existing under > views/{theme_name}/{view_file_path}, and if it exists, it calls that. > Otherwise, it defaults to views/admin/{view_file_path}. It's meant to > replace > $this->renderPartial calls in admin controllers. > > So, it's possible for gringegreen to override the views/admin/super/header > by putting the overriding file in views/gringegreen/super/header.php. > > In the repo is a sample, very rough, work-in-progress theme that puts > the admin backend onto a regular bootstrap layout. > > To switch views, you just have to configure the admin backend to use > the bootstrap theme. > > A few problems that I've come across: > 1. It's very difficult controlling the js and css packages because of the > registerPackage calls within the controller methods. For now, I'm calling > Yii::app()->getClientScript()->reset() so the overridden views has to > include the stylesheets and scripts on their own. > 2. AJAX-based/JS-based default views may not work as expected on > overridden views because of (1). > > Comments are welcome. > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > |
From: Rystraum G. <rys...@gm...> - 2014-01-13 18:08:43
|
Hi Sam, I'm assuming you're talking about this: http://www.yiiframework.com/doc/guide/1.1/en/topics.theming ? I'll rework what I have to try and start on using built-in Yii theming functions. Thanks! - Rystraum On Tue, Jan 14, 2014 at 1:53 AM, Sam Mousa <sa...@mo...> wrote: > Hi Rystraum, > > I haven't looked at your work specifically but I can tell you some general > things though. > - Yii already has built in theming support that we will be switching to in > the future. > - We do not want to replace the calls to render / renderPartial and other > variants, instead we should switch to only using them. > > Cheers, > > Sam > > > On Mon, Jan 13, 2014 at 6:13 PM, Rystraum Gamonez <rys...@gm...>wrote: > >> Hello, >> >> I was able to manage to enable other admin theme developers to be able to >> override existing admin views. >> >> It's available in my repo's fork, under the bootstrap branch. >> (https://github.com/rystraum/LimeSurvey/tree/bootstrap) >> >> Basically, it's a function that checks if the view file is existing under >> views/{theme_name}/{view_file_path}, and if it exists, it calls that. >> Otherwise, it defaults to views/admin/{view_file_path}. It's meant to >> replace >> $this->renderPartial calls in admin controllers. >> >> So, it's possible for gringegreen to override the >> views/admin/super/header >> by putting the overriding file in views/gringegreen/super/header.php. >> >> In the repo is a sample, very rough, work-in-progress theme that puts >> the admin backend onto a regular bootstrap layout. >> >> To switch views, you just have to configure the admin backend to use >> the bootstrap theme. >> >> A few problems that I've come across: >> 1. It's very difficult controlling the js and css packages because of the >> registerPackage calls within the controller methods. For now, I'm calling >> Yii::app()->getClientScript()->reset() so the overridden views has to >> include the stylesheets and scripts on their own. >> 2. AJAX-based/JS-based default views may not work as expected on >> overridden views because of (1). >> >> Comments are welcome. >> >> >> ------------------------------------------------------------------------------ >> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >> Learn Why More Businesses Are Choosing CenturyLink Cloud For >> Critical Workloads, Development Environments & Everything In Between. >> Get a Quote or Start a Free Trial Today. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >> _______________________________________________ >> limesurvey-developers mailing list >> lim...@li... >> https://lists.sourceforge.net/lists/listinfo/limesurvey-developers >> >> > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > |
From: Sam M. <sa...@mo...> - 2014-01-13 18:47:37
|
One problem that you'll probably run into is that we currently dont properly use Yii's view rendering in most admin views. So for us the first step is to get proper view rendering and after that theming should be a piece of cake! I think the global plugin settings are one of the few screens that actually use a proper layout and view file, you could look at that as a basis! Cheers, On Mon, Jan 13, 2014 at 7:07 PM, Rystraum Gamonez <rys...@gm...>wrote: > Hi Sam, > > I'm assuming you're talking about this: > http://www.yiiframework.com/doc/guide/1.1/en/topics.theming ? > I'll rework what I have to try and start on using built-in Yii theming > functions. > > Thanks! > > - Rystraum > > > On Tue, Jan 14, 2014 at 1:53 AM, Sam Mousa <sa...@mo...> wrote: > >> Hi Rystraum, >> >> I haven't looked at your work specifically but I can tell you some >> general things though. >> - Yii already has built in theming support that we will be switching to >> in the future. >> - We do not want to replace the calls to render / renderPartial and other >> variants, instead we should switch to only using them. >> >> Cheers, >> >> Sam >> >> >> On Mon, Jan 13, 2014 at 6:13 PM, Rystraum Gamonez <rys...@gm...>wrote: >> >>> Hello, >>> >>> I was able to manage to enable other admin theme developers to be able >>> to >>> override existing admin views. >>> >>> It's available in my repo's fork, under the bootstrap branch. >>> (https://github.com/rystraum/LimeSurvey/tree/bootstrap) >>> >>> Basically, it's a function that checks if the view file is existing >>> under views/{theme_name}/{view_file_path}, and if it exists, it calls that. >>> Otherwise, it defaults to views/admin/{view_file_path}. It's meant to >>> replace >>> $this->renderPartial calls in admin controllers. >>> >>> So, it's possible for gringegreen to override the >>> views/admin/super/header >>> by putting the overriding file in views/gringegreen/super/header.php. >>> >>> In the repo is a sample, very rough, work-in-progress theme that puts >>> the admin backend onto a regular bootstrap layout. >>> >>> To switch views, you just have to configure the admin backend to use >>> the bootstrap theme. >>> >>> A few problems that I've come across: >>> 1. It's very difficult controlling the js and css packages because of >>> the registerPackage calls within the controller methods. For now, I'm >>> calling Yii::app()->getClientScript()->reset() so the overridden views has >>> to include the stylesheets and scripts on their own. >>> 2. AJAX-based/JS-based default views may not work as expected on >>> overridden views because of (1). >>> >>> Comments are welcome. >>> >>> >>> ------------------------------------------------------------------------------ >>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>> Critical Workloads, Development Environments & Everything In Between. >>> Get a Quote or Start a Free Trial Today. >>> >>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> limesurvey-developers mailing list >>> lim...@li... >>> https://lists.sourceforge.net/lists/listinfo/limesurvey-developers >>> >>> >> >> >> ------------------------------------------------------------------------------ >> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >> Learn Why More Businesses Are Choosing CenturyLink Cloud For >> Critical Workloads, Development Environments & Everything In Between. >> Get a Quote or Start a Free Trial Today. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >> _______________________________________________ >> limesurvey-developers mailing list >> lim...@li... >> https://lists.sourceforge.net/lists/listinfo/limesurvey-developers >> >> > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > |
From: Tony P. <tpa...@pa...> - 2014-01-13 19:51:21
|
Can I put in my two cents on the general topic of theming? If possible, I would like to see a theme-specific JavaScript file included (like template.js). This would allow JS tweaks without hacking admin_core.js. Cheers, T. From: Sam Mousa [mailto:sa...@mo...] Sent: January-13-14 1:47 PM To: lim...@li... Subject: Re: [limesurvey-developers] Admin theme view overrides One problem that you'll probably run into is that we currently dont properly use Yii's view rendering in most admin views. So for us the first step is to get proper view rendering and after that theming should be a piece of cake! I think the global plugin settings are one of the few screens that actually use a proper layout and view file, you could look at that as a basis! Cheers, On Mon, Jan 13, 2014 at 7:07 PM, Rystraum Gamonez <rys...@gm...> wrote: Hi Sam, I'm assuming you're talking about this: http://www.yiiframework.com/doc/guide/1.1/en/topics.theming ? I'll rework what I have to try and start on using built-in Yii theming functions. Thanks! - Rystraum On Tue, Jan 14, 2014 at 1:53 AM, Sam Mousa <sa...@mo...> wrote: Hi Rystraum, I haven't looked at your work specifically but I can tell you some general things though. - Yii already has built in theming support that we will be switching to in the future. - We do not want to replace the calls to render / renderPartial and other variants, instead we should switch to only using them. Cheers, Sam On Mon, Jan 13, 2014 at 6:13 PM, Rystraum Gamonez <rys...@gm...> wrote: Hello, I was able to manage to enable other admin theme developers to be able to override existing admin views. It's available in my repo's fork, under the bootstrap branch. (https://github.com/rystraum/LimeSurvey/tree/bootstrap) Basically, it's a function that checks if the view file is existing under views/{theme_name}/{view_file_path}, and if it exists, it calls that. Otherwise, it defaults to views/admin/{view_file_path}. It's meant to replace $this->renderPartial calls in admin controllers. So, it's possible for gringegreen to override the views/admin/super/header by putting the overriding file in views/gringegreen/super/header.php. In the repo is a sample, very rough, work-in-progress theme that puts the admin backend onto a regular bootstrap layout. To switch views, you just have to configure the admin backend to use the bootstrap theme. A few problems that I've come across: 1. It's very difficult controlling the js and css packages because of the registerPackage calls within the controller methods. For now, I'm calling Yii::app()->getClientScript()->reset() so the overridden views has to include the stylesheets and scripts on their own. 2. AJAX-based/JS-based default views may not work as expected on overridden views because of (1). Comments are welcome. ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431 <http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk> &iu=/4140/ostg.clktrk _______________________________________________ limesurvey-developers mailing list lim...@li... https://lists.sourceforge.net/lists/listinfo/limesurvey-developers ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431 <http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk> &iu=/4140/ostg.clktrk _______________________________________________ limesurvey-developers mailing list lim...@li... https://lists.sourceforge.net/lists/listinfo/limesurvey-developers ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431 <http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk> &iu=/4140/ostg.clktrk _______________________________________________ limesurvey-developers mailing list lim...@li... https://lists.sourceforge.net/lists/listinfo/limesurvey-developers |
From: Rystraum G. <rys...@gm...> - 2014-01-15 08:47:53
|
Sam is right that LS doesn't use the built-in Yii render() method in the admin views. Another problem that I'm having is that a lot of the admin functions are very JS-driven but those JS files are registered in the controller methods, instead of within the views. As it stands, I've been able to make the global settings controller use the views and layouts properly but as I work through the other controllers, I may have to move JS inclusions from the controller to the views. I think it also addresses Tony's concern re: JS tweaks without hacking admin_core.js. - Rystraum On Tue, Jan 14, 2014 at 3:05 AM, Tony Partner <tpa...@pa...>wrote: > Can I put in my two cents on the general topic of theming? > > > > If possible, I would like to see a theme-specific JavaScript file included > (like template.js). This would allow JS tweaks without hacking > admin_core.js. > > > > Cheers, > > > > T. > > > > *From:* Sam Mousa [mailto:sa...@mo...] > *Sent:* January-13-14 1:47 PM > *To:* lim...@li... > *Subject:* Re: [limesurvey-developers] Admin theme view overrides > > > > One problem that you'll probably run into is that we currently dont > properly use Yii's view rendering in most admin views. > > So for us the first step is to get proper view rendering and after that > theming should be a piece of cake! > > > > I think the global plugin settings are one of the few screens that > actually use a proper layout and view file, you could look at that as a > basis! > > > > Cheers, > > > > On Mon, Jan 13, 2014 at 7:07 PM, Rystraum Gamonez <rys...@gm...> > wrote: > > Hi Sam, > > > > I'm assuming you're talking about this: > http://www.yiiframework.com/doc/guide/1.1/en/topics.theming ? > > I'll rework what I have to try and start on using built-in Yii theming > functions. > > > > Thanks! > > > > - Rystraum > > > > On Tue, Jan 14, 2014 at 1:53 AM, Sam Mousa <sa...@mo...> wrote: > > Hi Rystraum, > > > > I haven't looked at your work specifically but I can tell you some general > things though. > > - Yii already has built in theming support that we will be switching to in > the future. > > - We do not want to replace the calls to render / renderPartial and other > variants, instead we should switch to only using them. > > > > Cheers, > > > > Sam > > > > On Mon, Jan 13, 2014 at 6:13 PM, Rystraum Gamonez <rys...@gm...> > wrote: > > Hello, > > > > I was able to manage to enable other admin theme developers to be able to > > override existing admin views. > > > > It's available in my repo's fork, under the bootstrap branch. > > (https://github.com/rystraum/LimeSurvey/tree/bootstrap) > > > > Basically, it's a function that checks if the view file is existing under > views/{theme_name}/{view_file_path}, and if it exists, it calls that. > > Otherwise, it defaults to views/admin/{view_file_path}. It's meant to > replace > > $this->renderPartial calls in admin controllers. > > > > So, it's possible for gringegreen to override the views/admin/super/header > > by putting the overriding file in views/gringegreen/super/header.php. > > > > In the repo is a sample, very rough, work-in-progress theme that puts > > the admin backend onto a regular bootstrap layout. > > > > To switch views, you just have to configure the admin backend to use > > the bootstrap theme. > > > > A few problems that I've come across: > > 1. It's very difficult controlling the js and css packages because of the > registerPackage calls within the controller methods. For now, I'm calling > Yii::app()->getClientScript()->reset() so the overridden views has to > include the stylesheets and scripts on their own. > > 2. AJAX-based/JS-based default views may not work as expected on > overridden views because of (1). > > > > Comments are welcome. > > > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > > > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > > > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > > > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > limesurvey-developers mailing list > lim...@li... > https://lists.sourceforge.net/lists/listinfo/limesurvey-developers > > |
From: Marcel M. <maz...@we...> - 2014-01-30 21:28:25
|
Hi Limesurvey experts, a user is working on extending the Limesurvey API. Since he agreed to commit new functions to our repository, it would be nice if you could provide some assistance regarding the questions raised here: http://bugs.limesurvey.org/view.php?id=8633 Feel free to take over that ticket if you can help out. Thanks! Marcel Minke (Limesurvey Head of Support) |