Thread: [Phpsurveyor-developers] Bugs in labels.php
The leading Open Source survey tool
Brought to you by:
c_schmitz
From: Thibault Le M. <Thi...@su...> - 2007-02-14 17:52:24
|
During my quoting test I've noted 2 bugs in labels.php: 1- When using a labeset with several languages, though the Adding a label option is available on all languages folders, it only works if the last language folder is selected 2- A more serious issue, when modifying labels (labelsetanswers) in a labelset, I had other labelsets modified !!! Well, It's enough for me today... If anyone is working on PHPSV tonight, feel free tp have a look ;-) Regards, Thibault |
From: Thibault Le M. <Thi...@su...> - 2007-02-15 10:27:09
|
> 1- When using a labeset with several languages, though the=20 > Adding a label option is available on all languages folders,=20 > it only works if the last language folder is selected This is because labels.php creates several "insertcode" input texts : = once per language folder. Since there are several input texts with the same = name, only the last one is sent to the _POST variables. I can see 2 ways of patching this: A- Only display the "Add New Label" mask on the $first language folder * advantage: very simple patch * drawback: to add a Label to a language different from the first one, = the user'll have to first Add the Empty label code in the First language = folder, then go back to the used language folder to edit the label title B- Display the "Add New Label" mask on all languages folders, but = renaming the insertcode to insertcoe_$languageid * advantage: simple for the user * drawback: a little tricky to patch because, though only one insertcode_$languageid will be normally filled, the patch must add a = label for each insertcode_$languageid applied to each $languageids. I mean something like foreach ($languageids as $languageifd) { =20 //Quote=20 foreach ($languageids as $languageifd2) { //insert into labels (code,title,language) values (insertcode_$languageid,title_$languageid2,$languageifd2) } } I'm for solution A, though I can implement the second one if needed. I just need your decision. Thibault |
From: Thibault Le M. <Thi...@su...> - 2007-02-15 18:00:01
|
> > > 1- When using a labeset with several languages, though the > > Adding a label option is available on all languages folders, > > it only works if the last language folder is selected > > This is because labels.php creates several "insertcode" input > texts : once per language folder. Since there are several > input texts with the same name, only the last one is sent to > the _POST variables. > > I can see 2 ways of patching this: > > A- Only display the "Add New Label" mask on the $first language folder > * advantage: very simple patch > * drawback: to add a Label to a language different from the > first one, the user'll have to first Add the Empty label code > in the First language folder, then go back to the used > language folder to edit the label title Currently implemented in rev 2352. If you would prefer solution B below, let me know (or patch it yourself ;-)). > > B- Display the "Add New Label" mask on all languages folders, > but renaming the insertcode to insertcoe_$languageid > * advantage: simple for the user > * drawback: a little tricky to patch because, though only > one insertcode_$languageid will be normally filled, the patch > must add a label for each insertcode_$languageid applied to > each $languageids. I mean something like > > foreach ($languageids as $languageifd) > { > > //Quote > foreach ($languageids as $languageifd2) > { > //insert into labels (code,title,language) values > (insertcode_$languageid,title_$languageid2,$languageifd2) > } > } > > > I'm for solution A, though I can implement the second one if needed. > > I just need your decision. > > Thibault > > > > -------------------------------------------------------------- > ----------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the > chance to share your opinions on IT & business topics through > brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge &CID=DEVDEV _______________________________________________ PHPSurveyor-Developers mailing list PHP...@li... https://lists.sourceforge.net/lists/listinfo/phpsurveyor-developers |
From: Tom T. <tom...@he...> - 2007-02-16 00:25:17
|
Hi folks The 'submit' button isn't either closing windows or returning surveys to the specified 'End URL' value. The surveys are saving fine, so it may be a problem with some other incompatible query but I'm stuffed if I can see it. Is anyone else having this problem, or can anyone point me where to look - coz it's doing my head in? :) Thanks. Cheers Tom |
From: Thibault Le M. <Thi...@su...> - 2007-02-16 11:23:14
|
> Hi folks > > The 'submit' button isn't either closing windows or returning > surveys to the specified 'End URL' value. The surveys are > saving fine, so it may be a problem with some other > incompatible query but I'm stuffed if I can see it. > > Is anyone else having this problem, or can anyone point me > where to look > - coz it's doing my head in? :) Thanks. > > Cheers > Tom Fixed in rev 2355. It was an issue in the Templatereplace code for {SUBMITBUTTON}. I think my patch con't break anything cause {SUBMITBUTTON} only appears on the submit.pstpl files, but I might be wrong... Thibault |
From: Thibault Le M. <Thi...@su...> - 2007-02-15 18:00:49
|
> > 2- A more serious issue, when modifying labels > (labelsetanswers) in a labelset, I had other labelsets modified !!! Problem solved in rev 2353: was due to a missing WHER clause in the code handling Save_All labels. Regards, Thibault |