#195 Show tooltip when column too small to show text [patch]

closed-accepted
None
3
2011-04-15
2010-12-08
No

Greetings,

Currently, Liferea uses PANGO_ELLIPSIZE_END for the renderers of the Headline column.

It would be great, especially for those of us using the "Wide View", to be able to have a tooltip when the text gets truncated. Some collaborative blogs use a headline style like "[title], by [author]", and it would be great to be able to read the title without pressing the item, which toggles the unread flag. (I sometimes like to keep up with a particular author now, and leave the others for later reading.)

Notice this patch only shows a tooltip when the text size doesn't fit. If there is enough room, no tooltip is ever shown: which I guess, could be annoying.

---

The patch applies only to the news tree_view. Do you want me to come up with a more generic patch that would apply to the subscriptions tree_view as well?

Discussion

  • Ricardo Cruz

    Ricardo Cruz - 2010-12-08
    • priority: 5 --> 3
    • labels: --> 552939
     
  • Lars Windolf

    Lars Windolf - 2010-12-29

    Moving to patch tracker.

     
  • Lars Windolf

    Lars Windolf - 2010-12-29
    • labels: 552939 -->
     
  • Lars Windolf

    Lars Windolf - 2010-12-29

    Hi Ricardo!

    Thanks for contributing the patch. I believe this to be a useful feature.

    It isn't perfect yet: It does not work in all cases on unread items.
    Only when the text without bold style does not match the widget
    size is the tooltip shown. If the bold text size is larger than the
    widget size, but the normal text size isn't then no tooltip is shown.

    Do you know how to workaround this?

    Best Regards,
    Lars

     
  • Lars Windolf

    Lars Windolf - 2010-12-29
    • assigned_to: nobody --> llando
     
  • Ricardo Cruz

    Ricardo Cruz - 2010-12-30

    Hi Lars,

    Yeah, when I coded the patch, I thought that didn't happen often, but indeed I can see it is pretty annoying.

    I modified the patch, so that we specify the "font weight" (whether it is bold) to our temp PangoLayout object.

    I didn't try out this modification: it's so small, I thought it didn't deserve me applying it and compiling Liferea all over again. Please forgive me if it doesn't work.

    (I must say I noticed we were not doing an 'unref' on the PangoLayout object: fixed that. Otherwise, the memory cleaning seems fine: we only need to add another unref for the new PangoAttrList I added. PangoAttribute will be "taken over" by PangoAttrList, so that's fine as it is.)

    By the way, hope to see the upcoming Liferea release soon. ;-) If you guys are short of man-power, I may be able to help out... Tell me some feature that is broken/incomplete. Sadly, I will be pretty busy through January, and maybe part of Feb, but certainly afterwards. ;-)

     
  • Ricardo Cruz

    Ricardo Cruz - 2010-12-30

    I don't see the new file I attached. It is named: liferea-headline_tooltip-v2.patch

    If there's some problem, tell me, so I will re-upload it.

    This sourceforge bug tracker UI is giving me a headache. eheh ;-)

     
  • Lars Windolf

    Lars Windolf - 2011-01-03

    Hi Ricardo,

    I fear the second file didn't get attached :-(

    Cheers,
    Lars

     
  • Ricardo Cruz

    Ricardo Cruz - 2011-01-04

    Hi Lars,

    Okay, it seems the file was successfully attached now. Thanks, and good entrance into the new year!

     
  • Lars Windolf

    Lars Windolf - 2011-02-26
    • status: open --> open-accepted
     
  • Lars Windolf

    Lars Windolf - 2011-02-26

    Thanks for the second patch. It didn't apply automatically correctly, but I could still merge it.

    Works as expected now! To be released with next 1.7 version. Thanks again!

     
  • Lars Windolf

    Lars Windolf - 2011-04-15
    • status: open-accepted --> closed-accepted
     
  • Lars Windolf

    Lars Windolf - 2011-04-15

    Released with 1.7.5

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks