[Liferea-devel] case-sensitivity of the search feature

[Lars Lindner <lars.lindner@gm...>]

Some thoughts about the case-sensitivity:

- We need case-insensitive searches in the search dialog.

- The search methods of search dialog and Vfolders must
  be the same (to allow saving the search as a vfolder).

- Currently vfolders search rules are case sensitive.

- Vfolders are already slow.

- Case-insensitive vfolders will become even slower.
  (using g_utf8_casefold())

- Adding a case sensitivity flag to the search dialog
  is easy. Adding it to the vfolder dialog is very
  problematic. I think that's the reason why Evolution
  does not provide it.

So my idea is to make it case-insensitive per default.
Of course this will slow down all text matching vfolders.
But won't affect the unread/flagged vfolder.

Any comments?

Lars

Re: [Liferea-devel] case-sensitivity of the search feature

[Carlos Fenollosa Bielsa <topopardo@to...>]

I don't think a checkbox is a good idea. Everybody loves case
insensivity ;)

greetings

El dom, 20-03-2005 a las 21:42 +0100, Lars Lindner escribi=F3:
> Some thoughts about the case-sensitivity:
>=20
> - We need case-insensitive searches in the search dialog.
>=20
> - The search methods of search dialog and Vfolders must
>   be the same (to allow saving the search as a vfolder).
>=20
> - Currently vfolders search rules are case sensitive.
>=20
> - Vfolders are already slow.
>=20
> - Case-insensitive vfolders will become even slower.
>   (using g_utf8_casefold())
>=20
> - Adding a case sensitivity flag to the search dialog
>   is easy. Adding it to the vfolder dialog is very
>   problematic. I think that's the reason why Evolution
>   does not provide it.
>=20
> So my idea is to make it case-insensitive per default.
> Of course this will slow down all text matching vfolders.
> But won't affect the unread/flagged vfolder.
>=20
> Any comments?
>=20
> Lars
>=20
>=20
>=20
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick
> _______________________________________________
> Liferea-devel mailing list
> Liferea-devel@...
> https://lists.sourceforge.net/lists/listinfo/liferea-devel
--=20
Greetings from Carlos Fenollosa Bielsa
My weblog: http://weblog.topopardo.com
PGP Public key: 0xEE6097FC

Re: [Liferea-devel] case-sensitivity of the search feature

[A. Pagaltzis <pagaltzis@gm...>]

* Lars Lindner <lars.lindner@...> [2005-03-20 21:50]:
> Any comments?

Mostly only that it would be much easier if the database backend
had landed. :-) (Planned post-1.0, right?)

Being case-insensitive by default is sensible, IMHO. I'd venture
to say providing a checkbox wouldn't even be necessary, but
having (apparently inexplicable) different behaviour for searches
and VFolders sounds like a recipe for confusion. I'm not sure
what the best course of action is in this case...

Regards,
-- 
Aristotle
"If you can't laugh at yourself, you don't take life seriously enough."

Re: [Liferea-devel] case-sensitivity of the search feature

[Lars Lindner <lars.lindner@gm...>]

Am Sonntag, den 20.03.2005, 22:14 +0100 schrieb A. Pagaltzis:
> * Lars Lindner <lars.lindner@...> [2005-03-20 21:50]:
> > Any comments?
> 
> Mostly only that it would be much easier if the database backend
> had landed. :-) (Planned post-1.0, right?)

++

> Being case-insensitive by default is sensible, IMHO. I'd venture
> to say providing a checkbox wouldn't even be necessary, but
> having (apparently inexplicable) different behaviour for searches
> and VFolders sounds like a recipe for confusion. I'm not sure
> what the best course of action is in this case...

No. In no case there will be a different behaviour.
But another alternative would be to provide a checkbox
in both the search dialog and in the vfolder rule properties.
The first one would be no big problem, the second one is
some effort to implement and does not fit nicely into the
vfolder properties GUI.

Lars

Re: [Liferea-devel] case-sensitivity of the search feature

[A. Pagaltzis <pagaltzis@gm...>]

* Lars Lindner <lars.lindner@...> [2005-03-20 22:35]:
> No. In no case there will be a different behaviour.

So what are the options?

Always case-insensitive and slow VFolders, vs checkboxes on both
but awkward UI for VFolders?

*How* much slower does this make VFolders, anyway?

Regards,
-- 
Aristotle
"If you can't laugh at yourself, you don't take life seriously enough."

Re: [Liferea-devel] case-sensitivity of the search feature

[Lars Lindner <lars.lindner@gm...>]

Am Sonntag, den 20.03.2005, 23:14 +0100 schrieb A. Pagaltzis:
> * Lars Lindner <lars.lindner@...> [2005-03-20 22:35]:
> > No. In no case there will be a different behaviour.
> 
> So what are the options?
> 
> Always case-insensitive and slow VFolders, vs checkboxes on both
> but awkward UI for VFolders?

Exactly.

> *How* much slower does this make VFolders, anyway?

I changed the code and made some tests. g_utf8_casefold()
seems to be pretty fast. Since the search time already is in
the area of seconds (500 feeds, 100 items cache limit) I can
feel no difference. I'll check it in some minutes in case
you want to try.

Lars

Re: [Liferea-devel] case-sensitivity of the search feature

[Carlos Fenollosa Bielsa <topopardo@to...>]

If the backend changes to the DB, will VFolders still be slow? I mean,
if searching in vfolders is slow *now*, but when using the DB would get
faster, why bother now?

El dom, 20-03-2005 a las 23:29 +0100, Lars Lindner escribi=F3:
> Am Sonntag, den 20.03.2005, 23:14 +0100 schrieb A. Pagaltzis:
> > * Lars Lindner <lars.lindner@...> [2005-03-20 22:35]:
> > > No. In no case there will be a different behaviour.
> >=20
> > So what are the options?
> >=20
> > Always case-insensitive and slow VFolders, vs checkboxes on both
> > but awkward UI for VFolders?
>=20
> Exactly.
>=20
> > *How* much slower does this make VFolders, anyway?
>=20
> I changed the code and made some tests. g_utf8_casefold()
> seems to be pretty fast. Since the search time already is in
> the area of seconds (500 feeds, 100 items cache limit) I can
> feel no difference. I'll check it in some minutes in case
> you want to try.
>=20
> Lars
>=20
>=20
>=20
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick
> _______________________________________________
> Liferea-devel mailing list
> Liferea-devel@...
> https://lists.sourceforge.net/lists/listinfo/liferea-devel
--=20
Greetings from Carlos Fenollosa Bielsa
My weblog: http://weblog.topopardo.com
PGP Public key: 0xEE6097FC

Re: [Liferea-devel] case-sensitivity of the search feature

[Lars Lindner <lars.lindner@gm...>]

Am Montag, den 21.03.2005, 00:00 +0100 schrieb Carlos Fenollosa Bielsa:
> If the backend changes to the DB, will VFolders still be slow? I mean,
> if searching in vfolders is slow *now*, but when using the DB would get
> faster, why bother now?

Yes, it will get really fast. Nathan did some experiments a while
ago. I remember a mail he posted with some performance results
but cannot find it :-)

And you are right, this is one reason why it is not so critical now.