[Libyahoo2-devel] Wrong handling of status in yahoo_process_buddyadd()

[Wilmer v. d. G. <wi...@ga...>]

Hello,

It seems to me like yahoo_process_buddyadd() makes wrong assumptions
about the status field.

I had issues with BitlBee seeing "ghosts" online. It looks like the
cause is in the handling of this status field. My comments:

/* BitlBee: This seems to be wrong in my experience. I think:
   status = 0: Success
   status = 2: Already on list
   status = 3: Doesn't exist
   status = 42: Invalid handle (possibly banned/reserved, I get it for
                handles like joe or jjjjjj)
   Haven't seen others yet. But whenever the add is successful, there
   will be a separate "went online" packet when the auth. request is
   accepted. Couldn't find any test account that doesn't require auth.
   unfortunately (if there is even such a thing?) */

I just took out that code, but may be missing the case of people who
don't require auth requests (gain, no clue of that even exists on YMSG).

I also added a call to got_buddies since I let my IM modules ACK if an
add was successful as some layer of "error checking".

The full change is here:
http://bugs.bitlbee.org/bitlbee/changeset/devel%2C670


Wilmer.

-- 
+-------- .''`.     - -- ---+  +        - -- --- ---- ----- ------+
| wilmer : :'  :  gaast.net |  | OSS Programmer   www.bitlbee.org |
| lintux `. `~'  debian.org |  | Full-time geek  wilmer.gaast.net |
+--- -- -  ` ---------------+  +------ ----- ---- --- -- -        +