Re: [libxml++] My proposed patches

[Christophe de V. <cde...@al...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim Garrison wrote:

| The first patch adds cobj() to Document.


Is it a real need to have it ? I'd prefer not to introduce it.

| The second one adds the function
| Document::create_root_node_by_import.  I decided to leave the long
| name and not overload create_root_node for the sake of clarity; in
| the same manner, Node::import_node and Node::add_child are two
| differently named functions with analogous functionality.


Looks good to me.

|
| If you give me the word, I'll go ahead and commit it to the module,
|  or feel free to do it on your own.


If you have an access to gnome-cvs, please commit your second patch,
but don't forget to update and commit the ChangeLog at the same time.

Thanks,

Christophe

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAIoFzB+sU3TyOQjARAohcAKDVe4C/X8cZifC63aynO3G8y4gHGgCeODvE
pl6PQl3ova4lY7mbF4mPDKg=
=pH/2
-----END PGP SIGNATURE-----