[Libxmlplusplus-general] multi-node-types API changes

[Christophe de V. <cde...@al...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Murray,

Having a quick look at what you commited, I have a few small remarks, beside 
the fact that what you've done correspond almost exactly with what I was 
thinking about (yeepee we do agree ;-)

 - The TextNode doesn't need all these constuctors since it has no name (well, 
always the same), and no line number in libxml, although we could 
automaticaly give the parent line number to it.
 - As I said a couple of week ago, I do agree with you on the problem caused 
by the methods returning const references. So the name() method can become
string name() const;
 - Wouldn't a Clone() method simplify the Node(const Node * from) 
implementation ?
 - don't you think we could get rid of the _initialised attribute ? The only 
case it is set to false is when the name of the node is empty. Is it really 
necessary ? I have the feeling that not. If something wrong happens during a 
node initialisation, then we throw an exception...


As far as the children API in the Node type, I guess that keeping it there 
simplify it's use : there is not need to make any difference between all 
types of node to go through a tree. A TextNode is a node with 0 children 
after all.
So let's keep it like this as you suggest.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9/5Y5B+sU3TyOQjARAnGzAJsFtEaNJ+8w0fq2GZ6PqFSR25Kc8wCgvZS1
5CIuQWK3FtVNddgfg18OHZ4=
=23g5
-----END PGP SIGNATURE-----