libxmlplusplus-general

[libxml++] Segfault in dom parser

[Thomas J. <tho...@in...>]

Hi,

I've found a little bug I want to report:

Remove example.xml and try running the included example dom_parser.
It should segfault. Is it a bug of the example or the library?

Please CC: replies.

Cheers,
Thomas

Re: [libxml++] Segfault in dom parser

[Christophe de V. <cde...@al...>]

Le Jeudi 13 Mars 2003 20:59, Thomas Jarosch a =E9crit :
> Hi,
>
> I've found a little bug I want to report:
>

Thanks

> Remove example.xml and try running the included example dom_parser.
> It should segfault. Is it a bug of the example or the library?

The bug comes from the lib which doesn't check if context creation is=20
sucessfull. I'll commit a patch in a few minutes.

On context creation failure the lib will now throw an internal_exception wi=
th=20
the message "cannot create parsing context".
If anybody think a new exception type is needed for that just tell me we'll=
=20
discuss it. In the mean time at least we'll not have a segfault.


Best regards,

Christophe

Re: [libxml++] Segfault in dom parser

[Thomas J. <tho...@in...>]

> > Remove example.xml and try running the included example dom_parser.
> > It should segfault. Is it a bug of the example or the library?
>
> The bug comes from the lib which doesn't check if context creation is
> sucessfull. I'll commit a patch in a few minutes.

:-)

> On context creation failure the lib will now throw an internal_exceptio=
n
> with the message "cannot create parsing context".
> If anybody think a new exception type is needed for that just tell me w=
e'll
> discuss it. In the mean time at least we'll not have a segfault.

KISS =3D Keep It Simple Stupid

Though detecting a "file not found" error
via an exception could also be nice.

Thomas

Re: [libxml++] Segfault in dom parser

[Thomas J. <tho...@in...>]

Hi Christophe,

> > > Remove example.xml and try running the included example dom_parser.
> > > It should segfault. Is it a bug of the example or the library?
> >
> > The bug comes from the lib which doesn't check if context creation is
> > sucessfull. I'll commit a patch in a few minutes.
> >
> :-)
> :
> > On context creation failure the lib will now throw an internal_exception
> > with the message "cannot create parsing context".
> > If anybody think a new exception type is needed for that just tell me
> > we'll discuss it. In the mean time at least we'll not have a segfault.

I found another two segfaults :o)

- Zero byte file
- Special one byte file (attached)

The segfaults are reproducable with the dom parser example program.

Thomas

Re: [libxml++] Segfault in dom parser

[Christophe de V. <cde...@al...>]

Hi,

Le Samedi 14 Juin 2003 01:19, Thomas Jarosch a =E9crit :
>
> I found another two segfaults :o)
>
> - Zero byte file
> - Special one byte file (attached)
>
> The segfaults are reproducable with the dom parser example program.

which version did you use ? With 0.24 I do not have this segfault.

Cheers,

Christophe

Re: [libxml++] Segfault in dom parser

[Thomas J. <tho...@in...>]

> Le Samedi 14 Juin 2003 01:19, Thomas Jarosch a =E9crit :
> > I found another two segfaults :o)
> >
> > - Zero byte file
> > - Special one byte file (attached)
> >
> > The segfaults are reproducable with the dom parser example program.
>
> which version did you use ? With 0.24 I do not have this segfault.

I used version 0.23. I'll give 0.24 a try now.
(Didn't know 0.24 is out as freshmeat still thinks 0.23 is the newest versi=
on)

Thomas

Re: [libxml++] Segfault in dom parser

[Thomas J. <tho...@in...>]

> > > The segfaults are reproducable with the dom parser example program.
> >
> > which version did you use ? With 0.24 I do not have this segfault.
>
> I used version 0.23. I'll give 0.24 a try now.
> (Didn't know 0.24 is out as freshmeat still thinks 0.23 is the newest
> version)

Ok, 0.24 works perfect. Hope there aren't any setuid programs out there
using libxml++ 0.23 ;-)

Thomas

Re: [libxml++] Segfault in dom parser

[Christophe de V. <cde...@al...>]

Le Samedi 14 Juin 2003 01:52, Thomas Jarosch a =E9crit :
> (Didn't know 0.24 is out as freshmeat still thinks 0.23 is the newest
> version)
>

Strange. I did the release. I'll try to figure what's going on next week.

Cheers

Christophe