libxmlplusplus-general

[libxml++] SaxParser and getEntity

[Christophe de V. <cde...@al...>]

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

While removing libxml includes from headers I faced two little problems wit=
h=20
getEntity.
=46irst it has, for now, to return a libxml structure.
Second the default behavior to give to this callback function is not trivia=
l (=20
see http://mail.gnome.org/archives/xml/2003-April/msg00112.html ).

I think the ideal would be to wrap xmlEntity in a xmlpp::Entity class. But =
I=20
don't want to go for such a developpement now. If somebody really need it y=
ou=20
can propose a patch.

To make minimal changes, I want to do the following :
 - add a boolean parameter to the SaxParser constructor which tells if the=
=20
on_get_entity has to be called, with default value to false.
 - In order to overload this callback function, the lib user will have to=20
include himself libxml2 header to have the definition of xmlEntity since=20
saxparser.h only make a forward declaration of the struct.

Do you agree with that ?

Once it's done the libxml headers will not be included anymore by libxml++=
=20
users.

Regards,

Christophe
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+zfW1B+sU3TyOQjARAsVKAJ97NwI98YttAeUQGvHqMVLled4qoACeOl8s
cTMQpRRg/ynmFoYTAK7KPJI=3D
=3DvImA
=2D----END PGP SIGNATURE-----

Re: [libxml++] SaxParser and getEntity

[Jonathan W. <co...@co...>]

On Fri, May 23, 2003 at 12:19:32PM +0200, Christophe de VIENNE wrote:

> While removing libxml includes from headers I faced two little problems with 
> getEntity.
> First it has, for now, to return a libxml structure.
> Second the default behavior to give to this callback function is not trivial ( 
> see http://mail.gnome.org/archives/xml/2003-April/msg00112.html ).

If, as I believe, I was the only person using on_get_entity(), then I
suggest removing it entirely, at least until a better solution (possibly
with an Entity class) is devised.

jon


-- 
"A foolish consistency is the hobgoblin of little minds..."
	- Ralph Waldo Emerson

Re: [libxml++] SaxParser and getEntity

[Christophe de V. <cde...@al...>]

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Vendredi 23 Mai 2003 15:58, Jonathan Wakely a =E9crit :
> On Fri, May 23, 2003 at 12:19:32PM +0200, Christophe de VIENNE wrote:
> > While removing libxml includes from headers I faced two little problems
> > with getEntity.
> > First it has, for now, to return a libxml structure.
> > Second the default behavior to give to this callback function is not
> > trivial ( see http://mail.gnome.org/archives/xml/2003-April/msg00112.ht=
ml
> > ).
>
> If, as I believe, I was the only person using on_get_entity(),

you never know ! :-)

> then I suggest removing it entirely, at least until a better solution
> (possibly with an Entity class) is devised.

We'll see but I think the current solution is quite satisfying (you can tes=
t=20
it it's in the CVS).


Christophe
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+zi0YB+sU3TyOQjARAvKAAKDiDljf0gvsRLXzahlM8M4hQW48oACdHN+A
3A9hGUQcq8cnF9wsL08VZlI=3D
=3Dndts
=2D----END PGP SIGNATURE-----