libxmlplusplus-general

Re: [libxml++] [ libxmlplusplus-Patches-719921 ] patch to make it compile on NetBSD

[Ephraim V. <ef...@ep...>]

Sorry to come in late, I've seen the patch has already been commited, but
including <iostream.h> is not good.

The .h versions of the standard C++ includes are deprecated, in msvc at
least it includes an old version of iostream which is not compatible with
the new template based <iostream>.

I don't have access to NetBSD, but I imagine including <iostream> will work
since the h-less version is included everywhere else in the project.

regards,
-eff

Re: [libxml++] [ libxmlplusplus-Patches-719921 ] patch to make it compile on NetBSD

[Christophe de V. <cde...@al...>]

Le Dimanche 20 Avril 2003 13:19, Ephraim Vider a =E9crit :
> Sorry to come in late, I've seen the patch has already been commited, but
> including <iostream.h> is not good.
>

indeed. I did not see that it has been commited but my suggestion was to=20
remove it completely since it was needed for some useless tracing. We had=20
discussed a bit this issue but I did not change anything in this way so, I=
=20
should have been faster to act...

> The .h versions of the standard C++ includes are deprecated, in msvc at
> least it includes an old version of iostream which is not compatible with
> the new template based <iostream>.

definitely

>
> I don't have access to NetBSD, but I imagine including <iostream> will wo=
rk
> since the h-less version is included everywhere else in the project.
>

Probably, but in a very short time I'll commit the changes I spoke about in=
 a=20
previous thread.

Cheers

Christophe

Unhandled node types (was: Re: [libxml++] [ libxmlplusplus-Patches-719921 ] patch to make it compile on NetBSD)

[Christophe de V. <cde...@al...>]

Le Dimanche 20 Avril 2003 12:36, Christophe de Vienne a =E9crit :
> Probably, but in a very short time I'll commit the changes I spoke about =
in
> a previous thread.

So now an assert replace the warning message.
This means that some document containing some node type we do not wrap may=
=20
crash libxml++.
I guess that all the xmlElementType ending with _NODE has to be handled if =
we=20
want the assert not to be reached.
So the decision to make for now is do we=20
 1) implement the missing types
 2) remove the assert and silently ignore unknown types.

Comments / ideas are welcome


Regards,

Christophe

Re: Unhandled node types (was: Re: [libxml++] [ libxmlplusplus-Patches-719921 ] patch to make it compile on NetBSD)

[Ephraim V. <ef...@ep...>]

I feel the assert makes the library less useful in its current state. The
code may never need to access unsupported node types, since the really
useful nodes are supported, but the assert will exit the program anyway.

So until all types are supported, or explicitly ignored, I think the warning
message _was_ the most useful solution. silently ignoring the unknown types
comes second.

-eff

----- Original Message -----

So now an assert replace the warning message.
This means that some document containing some node type we do not wrap may
crash libxml++.
I guess that all the xmlElementType ending with _NODE has to be handled if
we
want the assert not to be reached.
So the decision to make for now is do we
 1) implement the missing types
 2) remove the assert and silently ignore unknown types.

Comments / ideas are welcome