Menu

#7 Fix wrong Lotus version detection

Unstable_(example)
closed-fixed
nobody
patch (1)
2
2023-05-02
2019-10-30
erAck
No

Attached is a patch that fixes a wrong Lotus version 1 instead of 2 detection. For details see commit message in patch file.

1 Attachments

Discussion

  • Anonymous

    Anonymous - 2019-10-30

    This looks sane to me.
    Alonso: do you have any further comments?
    Miklos

     

    Last edit: Miklos Vajna 2019-10-30
  • alonso laurent

    alonso laurent - 2019-10-31

    Hello,
    I must take a closer look, but this patch seems to break a lot of formula in wb1 files ;

    • so either we find a most robust way to know if a file is a wk1 or a wk3 file,
    • or we have to choose between breaking many .wk1 formula or the .wk3 formula which contain reference to a cell with a column greater than 256 :-~
     

    Last edit: alonso laurent 2019-10-31
  • alonso laurent

    alonso laurent - 2019-10-31

    I just have commit a quick patch (which allows to reference relative row between 1 and 2048). This must fix the given bug for TEST3.WK1 and do not break my test files (in fact, this repairs 5 conversions).

    Note:

    • I must relaunch my virtual machines to check what is the maximum numbers of allowed rows in wk1, wks(dos), ... because I suppose that it is not 256 :-~
     
  • alonso laurent

    alonso laurent - 2019-10-31

    I have commited some changes, I suppose that there will fix most problems...

     
  • alonso laurent

    alonso laurent - 2023-05-02
    • status: open --> closed-fixed
     

Anonymous
Anonymous

Add attachments
Cancel