Re: [Libwpg-devel] some problems with bitmaps

[Fridrich S. <fri...@bl...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi, Ariya,

Ariya Hidayat wrote:
> OK. I'll have  a look, although likely I'm going to do something
> useful only on the weekend. Also, if you have more variants of the
> bitmaps, just send them to me. I found out with X3, it's almost
> possible (or I simply miss it) to create less-than-8-bit bitmaps.

Yeah, these pictures are extracted from documents that we have in our
libwpd regression suite using an if zero-ed debug code. Now, there is
something with the line length or so in the RLE. I was just thinking
whether one could not be safer to use internally a std::vector <
std::vector < char > > to do the RLE decoding instead of having a flat
array of the size of data_size*width*height. Like this, we would even
avoid a possibility of the kind of security problems we had some times
ago in libwpd. And for std::vector < T > t, it is mandated by the
standard that if it is not empty, &t[0] points to the beginning of the
wrapped array and that this one is stored in contiguous memory space.

I would try to do something, but I guess that it would take me much more
time to go through the RLE decoding logic then it would take you :-)

Take your time, I am not rushing anything, although the Debian OOo
maintainer is breathing fire on my neck for a release of libwpg, but who
cares pushy Debian maintainers :-P

Cheers

F.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFGi2M8u9a1imXPdA8RAhKvAJ4oYtyyM/pTgMoRq2gYOCOdyKzRxACfW/hY
lMdqVBysahLlJizgCdW65AI=
=RROi
-----END PGP SIGNATURE-----