Re: [Libwpg-devel] libwpg-0.2.2/src/lib/WPG2Parser.cpp:1030: possible bad expression ?

[David T. <dt...@re...>]

Hi,

On Mon, Dec 30, 2013 at 02:02:34PM +0000, David Binderman wrote:
> [WPG2Parser.cpp:1030]: (style) Expression '(X & 0x40) == 0x1' is always false.
> [WPG2Parser.cpp:1031]: (style) Expression '(X & 0x80) == 0x1' is always false.
> 
> Source code is
> 
>     bool granular = (flag & (1<<6)) == 1;
>     bool anchor = (flag & (1<<7)) == 1;

Indeed. I suppose the intent was the same as on lines 1004/1005, i.e.,

bool granular = ((flag & (1<<6))>>6) == 1

. But it is in debug code, so it is not a big deal.

> 
> Maybe
> 
>     bool granular = (flag & (1<<6));
>     bool anchor = (flag & (1<<7));
> 
> might be better code.

Yes, definitely. I committed that change.

D.