[Libwpg-devel] libwpg-0.2.2/src/lib/WPG2Parser.cpp:1030: possible bad expression ?

[David B. <dc...@ho...>]

Hello there,

I just ran the static analysis tool "cppcheck" over
the source code of libwpg-0.2.2. 

It said many things, including

[WPG2Parser.cpp:1030]: (style) Expression '(X & 0x40) == 0x1' is always false.
[WPG2Parser.cpp:1031]: (style) Expression '(X & 0x80) == 0x1' is always false.

Source code is

    bool granular = (flag & (1<<6)) == 1;
    bool anchor = (flag & (1<<7)) == 1;

Maybe

    bool granular = (flag & (1<<6));
    bool anchor = (flag & (1<<7));

might be better code.

Regards

David Binderman