#32 x11vnc 0.9.10 0.9.11, 0.9.12 all failed compile

[fk hp]

make[3]: Entering directory `/var/tmp/portage/x11-misc/x11vnc-0.9.12/work/x11vnc-0.9.12/x11vnc'
if i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -D_REENTRANT -O2 -march=pentium-m -fomit-frame-pointer -pipe -Wall -MT x11vnc-connections.o -MD -MP -MF ".deps/x11vnc-connections.Tpo" -c -o x11vnc-connections.o `test -f 'connections.c' || echo './'`connections.c; \ then mv -f ".deps/x11vnc-connections.Tpo" ".deps/x11vnc-connections.Po"; else rm -f ".deps/x11vnc-connections.Tpo"; exit 1; fi
In file included from connections.c:55:0:
pointer.h:42:13: error: ‘pointer’ redeclared as different kind of symbol
/usr/include/X11/Xdefs.h:53:15: note: previous declaration of ‘pointer’ was here

[fk hp]

xorg-server 1.8.2 1.8.99.905

[fk hp]

pointer.h:42:
#ifndef _X11VNC_POINTER_H
#define _X11VNC_POINTER_H

/* -- pointer.h -- */

extern int pointer_queued_sent;

extern void initialize_pointer_map(char *pointer_remap);
extern void do_button_mask_change(int mask, int button);
extern void pointer(int mask, int x, int y, rfbClientPtr client);
extern int check_pipeinput(void);
extern void initialize_pipeinput(void);
extern void update_x11_pointer_position(int x, int y);

#endif /* _X11VNC_POINTER_H */

/usr/include/X11/Xdefs.h:53:

#ifndef _XTYPEDEF_POINTER
# define _XTYPEDEF_POINTER
typedef void *pointer;
#endif

[Johannes Schindelin]

Could you try the branch fix-3043646 which I just pushed?

[fk hp]

fix-3043646 failed compile:

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -D_REENTRANT -mtune=core2 -march=core2 -O2 -msse4.1 -pipe -ftracer -Wall -MT x11vnc-macosx.o -MD -MP -MF .deps/x11vnc-macosx.Tpo -c -o x11vnc-macosx.o `test -f 'macosx.c' || echo './'`macosx.c
linuxfb.c: In function 'console_guess':
linuxfb.c:156:8: warning: ignoring return value of 'read', declared with attribute warn_unused_result
keyboard.c: In function 'pipe_keyboard':
keyboard.c:2901:17: error: expected ')' before ',' token
keyboard.c:2903:17: error: expected ')' before ',' token
keyboard.c:2873:21: warning: unused variable 'y'
keyboard.c:2873:7: warning: unused variable 'x'
make[3]: *** [x11vnc-keyboard.o] Error 1

[fk hp]

[fk hp]

fix-3043646 compiled and work after the patch applied

[Johannes Schindelin]

Thanks. I amended that commit and forced a push to the branch. Karl, I think this is ready to be merged if you agree as to the approach of renaming "pointer" to "do_pointer". (Unless fk hp wants to be attributed properly, in which case I will gladly amend the commit another time.)

[fk hp]

if there's no problem just push it, fk hp does not need to be attributed.

[Karl J. Runge]

This has already been fixed since Aug 17, 2010 in the x11vnc 0.9.12 development tarball.