VISCA_RESPONSE_CLEAR may be incorrect
Brought to you by:
ddouxchamps
It appears that no response should be sent to a
IF_CLEAR command. There is a #define in libvisca.h
which appears to be VISCA_RESPONSE_CLEAR 0x40 which
might be incorrect.
In _VISCA_get_reply, iface->type is tested for
equality with VISCA_RESPONSE_ACK until the recieved
message is no longer the acknowledge (ACK) message.
Thereafter there is a case statement:
case VISCA_RESPONSE_CLEAR:
return VISCA_SUCCESS;
break;
Which is impossible because the header file defines
both VISCA_RESPONSE_ACK and VISCA_RESPONSE_CLEAR as
having the same value.
It is unclear to me if this issue has a malicious
dimension to it, the bug may be completely benign,
but the collission suggests something somewhere is
not right.