From: Xiaofan C. <xia...@gm...> - 2013-09-07 09:31:15
|
On Fri, Sep 6, 2013 at 6:58 PM, Hans de Goede <hde...@re...> wrote: > On 09/05/2013 03:14 AM, Xiaofan Chen wrote: >> On the other hand, maybe we then have to document this limitation >> of libusb-compat. > > You mean simply document that atexit is used and apps must not make any > calls from atexit because there are no ordering guarantees? Or you mean revert > the patch and then document the resource leak ? If there are no better solution, then we should revert the patch and document the resource leak. > Also what do others think? Pete ? Nathan ? > > >> BTW, do we need to replicate the libusb.org libusb-compat tickets in >> libusbx github? Only Ticket 110 and 32 need to be copied as other >> tickets have been closed. >> http://www.libusb.org/report/10 >> >> If yes, then I will copy the two tickets and add "Compat" in the >> beginning of the description to distinguish them from libusbx tickets. > > I think we should not count on libusb.org trac being available for ever, > so yes cloning open issues seems like a good idea. > > About adding a "Compat: " header to the description, wouldn't it be > better to simply enable issue tracking on: > https://github.com/libusbx/libusb-compat-0.1 > > Here: > https://github.com/libusbx/libusb-compat-0.1/settings > > Instead, and then file issues for it here: > https://github.com/libusbx/libusb-compat-0.1/issues > Good idea. Done. -- Xiaofan |