From: Dmitry F. <dm...@da...> - 2015-12-02 08:09:10
|
> On 2 Dec 2015, at 10:04 AM, Chris Dickens <chr...@gm...> wrote: > > Hi Dmitry, > > I see UsbDk v1.0.8 was just released. I'm ready to get started on > integrating this, but a few action items (based on the v4 branch): > > 1) The first commit that adds windows_nt_common.c breaks the VS > builds. Please have each commit that adds or changes file names also > include updates to the VS projects, libusb_sources, and affected .dsp > files as they go, instead of all at the end. > 2) The clock_gettime code in windows_nt_common.c is based on the > previous implementation. Please update this to match the current > implementation. > 3) Can we rename all the win_* functions to windows_*? We don't > abbreviate anywhere else, and I'd like the naming to be consistent. > Similarly, I don't think we need "backend" in any of the function > names (e.g. win_backend_get_fd can simply be windows_get_fd). > 4) win_transfer_callback() is not used outside of windows_nt_common.c, > so please make this static and remove from the header file. > > Thanks again for all your work on this! Hi Chris, I’m glad we’re moving forward, thanks for your efforts. I’ll go over your comments and come up with updated patches. Regards, Dmitry > > Regards, > Chris > > On Sun, Nov 22, 2015 at 12:23 AM, Dmitry Fleytman <dm...@da...> wrote: >> Hello Chris, >> >> Ping! :) >> >> Do you need any help from me, i.e. rebase etc. to proceed? >> >> ~Dmitry. >> >> On 28 Oct 2015, at 08:41 AM, Dmitry Fleytman <dm...@da...> wrote: >> >> Hello Chris, >> >> Any news regarding this? >> >> Thanks, >> Dmitry >> >> On 28 Jul 2015, at 07:46 AM, Chris Dickens <chr...@gm...> >> wrote: >> >> Hi Dmity, >> >> Yes, I will proceed with the UsbDk patches following the 1.0.20 release. >> Hopefully that will be finalized within a few weeks. >> >> Thanks for your patience! >> >> Regards, >> Chris >> >> On Mon, Jul 27, 2015 at 1:05 AM, Dmitry Fleytman <dm...@da...> wrote: >>> >>> >>> On Jul 27, 2015, at 10:52 AM, Xiaofan Chen <xia...@gm...> wrote: >>> >>> On Sun, Jul 26, 2015 at 5:59 PM, Dmitry Fleytman <dm...@da...> >>> wrote: >>> >>> Hello Chris, >>> >>> I see that version 1.0.20 was released recently. Does this mean you’ll >>> proceed with UsbDk patches anytime soon? >>> Do you need any help from us in order to have this merged? >>> >>> Thanks in advance, >>> Dmitry >>> >>> >>> Where did you find the 1.0.20 release? >>> >>> >>> Oops, I think I was mislead by some recent mailings on the list… >>> Now I see it is not released yet :) >>> >>> >>> On May 5, 2015, at 08:29 AM, Chris Dickens >>> <chr...@gm...> >>> wrote: >>> >>> Hi Dmitry, >>> >>> Thanks for all your work on this. Sorry this has been a slow process--I've >>> got a lot of other things on my plate. As you may have seen, I've just >>> released a patch series that has been in the works for quite some time. I >>> would like to get this merged and v1.0.20 released ASAP, then have a much >>> quicker development cycle for v1.0.21 that will include usbdk. I'm >>> reviewing >>> this latest usbdk patch series now. >>> >>> Regards, >>> Chris >>> >>> >>> >>> -- >>> Xiaofan >>> >>> >> >> >> |