From: Xiaofan C. <xia...@gm...> - 2011-08-22 07:55:32
|
On Mon, Aug 22, 2011 at 6:55 AM, Pete Batard <pe...@ak...> wrote: > On 2011.08.21 05:28, Vitali Lovich wrote: >> What is the harm in them living in mainline? It's just a few files. > > From my past experience, the people in charge of mainline seem to > prefer "uncluttered" over "helpful to our users". But maybe you'll have > better luck. > > As far as I'm concerned, while I wouldn't mind having all the cmake > files into a single separate contrib/ directory, to make it abundantly > explicit that CMake is not an officially supported method of buidling > libusb (insofar as anything in my repo can be official), I don't have > much of an issue with the extra CMakeList.txt in each directory, so your > patches should be OK once they're finalized. But you will have to submit > them to -stuge or mainline yourself, if you want them there. > I am not a CMake expert but it seems to me that it is not possible to put the files into a single separate contrib/ directory, similar to the WDK related "sources" files. In the WDK cases, the solution is to use ddk_build.cmd to create these files and copy them to the correct locations. So probably you can do the same to create a batch file or shell script to copy the CMake files to their correct location but it does not seem to be too intuitive that the user needs to run a batch file or a shell script first before running CMake. -- Xiaofan |