From: Pete B. <pb...@gm...> - 2010-12-07 18:59:39
|
On 2010.12.07 18:16, Segher Boessenkool wrote: > What you are missing is that all people who need the build files > with LF line endings, need *all* text files with LF line endings. Which means that people using Tgit and MSVC (CRLF) are supposed to retrieve all their files including the autotool ones with CRLF, and cannot switch environments without a new pull (provided they set their options right). Or people who use MinGW/cygwin must ensure they use LF always, even as the expectation is that gcc handles LF or CRLF sources transparently, so the only files that actually *need* to be LF are non .c/.h Do we expect to support a cygwin/MinGW gcc that can't handle CRLF? If not, then your *all* is inaccurate, and we have no need to enforce LF for platforms that are supposed to need LF, apart from the files that are not .c/.h. Let's see what these files should be for cygwin or MinGW (which are the Windows platforms supposed to require LF): First we eliminate all the MSVC/DDK stuff. Then, I wouldn't care too much about README/TODO etc. The .rc/.def are probably fine either way (if not, they would be expected to be CRLF rather than LF, since these are supposed to be MS generated files). Which leaves... .sh/.ac/.am as the ONLY files that actually *need* LF line endings... Again, why force-convert files if we don't have to? Unless we want to consider that MinGW and cygwin's gcc will break on CRLF (for a gcc specifically aimed at a platform where the default is CRLF), I still don't see much of an issue with the -crlf solution, especially as it allows moving files around between envs almost freely Regards, /Pete |