From: Pete B. <pb...@gm...> - 2010-12-05 20:46:28
|
On 2010.12.05 20:29, Michael Plante wrote: > This one needs to be separate from the rest of my replies because of the > quoting I'm doing here... > > Pete Batard wrote: >>> As you pointed out earlier, I applied the safecrl settings advised by >>> Peter when I started my branch (I remember getting my fingers slapped on >>> this list for not using it). > > Sorry, my recollection (and my search of my email) indicates that you never > used safecrlf. On 1/14, you said: My bad, I meant autocrlf, sorry about that. I did indeed get my fingers slapped for not using autocrlf, and, as you pointed out, had issues with safecrlf so I didn't use it. For the record, neither are set by default in Tgit (or at least they weren't in the versions I used so far). > Only on 12/3 has Peter even hinted at a different story, and only after you > revealed that you're still not using safecrlf: > >>>> my git/config for libusb is attached. [mkp note: it shows > safecrlf=false] >>> >>> Hm. You set safecrlf explicitly. My git config --help doesn't say >>> what the default is, but I don't think safecrlf=false can ever be >>> harmful. But I think autocrlf=true explains why you need -text in >>> your repo. Peter also indicated that autocrlf should be set to input lately: On 2010.12.02 02:13, Peter Stuge wrote: > Maybe we could have helped. I did some testing just now and it seems > that: > > git config core.autocrlf input > > Will make sure that I get files exactly as they are in the repo, > without any CRLF conversion at all. If I want to, I can force CRLF > locally with: > In short, I currently have no idea what settings I should use (probably "input" though I would need to test that it results in files being stored in the right format), and I don't see forcing people to use autocrlf / safecrlf just to get specific files with the right terminators as a better option than making sure that anybody gets the right terminator on the files that matter, regardless of their option. We will get users not applying the settings we expect. We can EASILY address that. The only question is not doing it on the pretence that, for some weird reason, we think that git should store MS project files LF'd in its repo, and that some people might ever want to retrieve the .sh/.ac/.am as CRLF, which really doesn't make any sense. Regards, /Pete |