From: Segher B. <se...@ke...> - 2010-12-05 04:00:13
|
>> Checked out text files should have the line endings your OS and tools >> expect, not what whoever checked them in prefers. > > Again you misconstrue what I am saying. It's not a matter of > preference. The point is that what line endings _I_ get on _my_ system should not depend on what problems _you_ have with line endings on _your_ system. > It's a matter that cygwin can't deal with CRLF'd .sh (and > .ac), and Linux can't deal with CRLF'd .am. Neither system likes any CR. The Cygwin manual says this: "Binmode is the best choice usually since it's faster and easier to handle, unless you want to exchange files with native Win32 applications. It makes most sense to keep the Cygwin distribution and your Cygwin home directory in binmode and generate text files in binmode (with UNIX LF lineendings). Most Windows applications can handle binmode files just fine. A notable exception is the mini-editor Notepad, which handles UNIX lineendings incorrectly and only produces output files with DOS CRLF lineendings." > This is the problem we're > actually trting to solve here, i.e. how do we prevent people from > checking out libusb and have problems building it. You cannot prevent people from shooting themselves in the foot, and you shouldn't even try, there are always plenty of people who manage anyhow. > Without -crlf, we can't, unless we start preventing the use of some > git versions (and even then, I'm pretty sure people can screw up their > options in Linux or cygwin, to end up with line terminators that they > shouldn't have. And all evidence so far shows it causing more problems, and more bizarre problems, than it solves. Not good. > Fact: autotools and scripts do not handle CRLFs without problems => Fact: those are bugs. > we > MUST have LF's always on these files, no matter the platform. Fact: that does not work on every platform. It might be a suitable workaround for the aforementioned bugs on YOUR platform, but that is no reason to punish everyone else. >> You really want to punish all unix users because some mswindows users >> cannot sort out their work environment? Â And you really think that is >> acceptable? > > How is enforcing the UNIX default terminators on all platforms (for > .sh/.am/.ac - it should be obvious that the .c/.h is not what I'm > talking about here) punishing UNIX users? We now have to think about your strange workarounds and mark every new file we check in. This matters. It is the same issue as saying "we'll just write all file lists on one line", instead of figuring out what the problem is. It all adds up. It makes everything *more work* for everyone (but you), not less. Segher |