From: Pete B. <pb...@gm...> - 2010-12-04 19:05:21
|
On 4 December 2010 14:28, Segher Boessenkool <se...@ke...> wrote: > Checked out text files should have the line endings your OS and tools > expect, not what whoever checked them in prefers. Again you misconstrue what I am saying. It's not a matter of preference. It's a matter that cygwin can't deal with CRLF'd .sh (and .ac), and Linux can't deal with CRLF'd .am.This is the problem we're actually trting to solve here, i.e. how do we prevent people from checking out libusb and have problems building it. Without -crlf, we can't, unless we start preventing the use of some git versions (and even then, I'm pretty sure people can screw up their options in Linux or cygwin, to end up with line terminators that they shouldn't have. >> All we need to do is ensure the files we care about have the right >> line endings, and it won't matter who retreives files on which OS and >> with which tools. A .dsw retreived on any platform will have CRLF >> (provided it was checked in with CRLF, which should be the case if >> .gitattributes applied at the time of checking in) and a .sh will have >> LF. > > Is that really what the various POSIX(-like) environments on mswindows > expect? It's what cygwin need, and if for any reason (copied the files from Windows or something) you have CRLF's in in your .am, you'll get errors on Linux to. Fact: autotools and scripts do not handle CRLFs without problems => we MUST have LF's always on these files, no matter the platform. Not a matter of preference, but a matter of preventing our users from wasting their time. >> So UNIX people can package files for MS users, and life's just >> peachy. >> >> The only issue is if the same file *must* be CRLF in one environment >> and LF in another, but we have no such item. > > Except all our text files, i.e. almost everything. Please re-read. Michael got it. >> Our .sh/.am/.ac must be LF in all environments, > > Got proof of that? Read my previous e-mails. I already told you guys the bad things that I saw happen iwth CRLF'd .sh/.am/.ac.. > You really want to punish all unix users because some mswindows users > cannot sort out their work environment? And you really think that is > acceptable? How is enforcing the UNIX default terminators on all platforms (for .sh/.am/.ac - it should be obvious that the .c/.h is not what I'm talking about here) punishing UNIX users? Seriously, please review the issue that prompted this discussion. As to the MSVC project files, if UNIX users want to edit them, they'd better make sure the line terminators used match the ones expected by the Windows tool, so again, no issue. > I also would prefer not to have to set attributes on every second > file in the repo, sigh. Same here, but for some files, we don't really have a choice, unless we expect everyone to be a git expert on CRLF conversion (which even git experts seem to have trouble with). Regards, /Pete |