From: Michael P. <mic...@gm...> - 2010-12-04 04:09:11
|
Segher Boessenkool wrote: >> Classic "more" does not work correctly. "cat" does not work. I just tried them now against a CRLF source file. I don't see any problems. What doesn't work for you? (sys-apps/util-linux-2.17.2 , sys-apps/coreutils-8.5 , respectively) I checked the sourcefile with hexdump -C |less for 0D 0A, just to be sure that the test was valid. >> "vi" does >> not work (and neither does vim in some configurations, and sometimes it >> guesses wrong I don't usually use vi[m], so that's possible. >> (when you have unicode on the first line, in some cases, >> for example)). Ok, I admit unicode is not really a concern for me. I can see how it would be for other people. >> "grep" does not work. How so? It works for me. Again, just tried it, and it found what I searched on. (sys-apps/grep-2.5.4-r1) >> "diff" does not work. "patch" >> makes a mess. Well, now you're getting into utilities that touch more than one file at a time. Do you mean with two different line ending styles now, or both CRLF? If the latter, diff works. I guess as long as I put that caveat there, I should point out that windiff works ok as long as the line endings match between two files. I rarely use patch, so I don't know there. >> Won't notepad mutilate all files with a UTF marker at the start? I have no idea. Never been a concern to me. I don't think Unicode belongs in source code, anyway. Maybe docs, but that's iffy... But keep in mind that most references to Unicode in the context of Windows are UTF-16 (always 2 bytes, no matter what is represented), so that would obviously make a mess of most files, since every other byte is 0x00 on average. >> So you want all source code (and other text files) to be checked out in >> CRLF; and the MSVC files as binary. text: yes. MSVC: Forced CRLF, particularly since CRLF may make the upcoming snapshot-generation script easier to write. The snapshots will be generated by Peter on his server, which is most certainly not running Windows. ;) >> And you do not care about Makefiles >> and configure.ac etc.? On Windows, I agree, and I believe there are enough other people testing on other platforms that I'm unlikely to be the first person to catch any problems on these anyway. >> It sounds to me like the default config of msysgit should work fine for >> you. Meaning specifically which settings of autocrlf and safecrlf? Recall that I mentioned Peter, from the very beginning, suggested setting those explicitly to true. So if you're suggesting I unset them, I'd like to hear more details. Keep in mind my configuration was working just fine for 7-8 months until the August .gitattributes patch came along. I guess I can also point out here that I don't recall the .gitattributes changes for the LF files being an issue. I'm only re-voicing my earlier concerns in order to make sure no one says "one .gitattributes patch fails to cause problems, so they must all be ok", particularly when it sounds like the patch isn't going to be accepted as-is. Thanks, Michael |