Re: [Libusb-devel] libusb-stuge.git broke cygwin compilation

[Pete B. <pb...@gm...>]

On 2010.12.01 19:39, Peter Stuge wrote:
> Actually here the distinct commits help a lot, specifically *because*
> we're still learning about configure.ac. It makes each step clear for
> reviewers. You may already have noticed that several of the commits
> touch the same code, and quite a lot of information about the way
> from point A in the code to point B would have been lost if
> everything was jammed into a single commit.

I'm not talking about a single commit, but dealing with whitespaces and 
quotation could really be done in a single commit, especially when 
there's more to process.

> Very difficult to review,

Not really. I find it more difficult to find out where you guys are 
headed as it takes 9 commits to see the big picture.

> and I think not acceptable at least for anything in libusb core.

It is acceptable for configure.ac, especially if actual code is waiting. 
configure.ac is just a recepy, and none of the changes we're discussing 
here are changing even a single bit of the final libusb binary. single 
or multiple lines? not one bit. using an alias for nfds_t? not a sinle 
bit. I'm hard pressed to see how this benefits our users.

> It is very much a part of the work to prepare the next release.

How's that crucial to 1.0.9? Why could it not wait for 1.0.10 or 1.0.11 
when there's more than enough patch submissions to keep us busy without 
even wanting to overhaul configure.ac? People are not waiting for us to 
release libusb with an overhauled configure.ac. They're waiting for 
hotplug, timestamped logging, libusb-win32 and all the good features we 
know we have to do, but that are ever delayed because we're chosing to 
waste out time on this "oh, but it will make things so much better if we 
do it now - just wait and see" crap.

> One change = one commit.

OK. I guess I'm going to start producing one commit for every option I 
change in the MS project files. Linux and OS-X people should be thrilled 
the day we have 9 commits in a row just for MS project files.

> I rebased quite frequently making those changes, because I didn't
> have a plan and was learning along the way, and because I discovered
> more and more things to fix. This is why I like personal repos -
> they're a sandbox, but still allow easy review so that the sandcastle
> can be made even greater. :)

Yeah, expect at the end of the day, you've only built your own little 
sandcastle model, and people have brought a ton of bricks for the actual 
house, that have been left untouched...

Regards,

/Pete