Re: [Libusb-devel] Large receive buffer size causes an error?

[Segher B. <se...@ke...>]

>> libusb-stuge.git is the current state of my working tree. That is
>> rebased frequently, but I only expect one split in there for now,
>> and a few commit message changes. If anyone wants to review these
>> commits, even if they will still change a little further, please go
>> for it! I'll take into account any and all comments in my further
>> work.
>
> libusb-stuge broke cygwin compilation.
>
> Getting the following when running configure from autogen.sh:
>
> ...
> checking for sys/time.h... yes
> configure: creating ./config.status
> .in'ig.status: error: cannot find input file: `
>
> Yup, the last line is verbatim.

Wow, that's...  special?  What on earth is going on there!

> And I'm going to rant again, but was it really necessary to split the
> configure.ac changes into 9 commits? What good will come of going atomic
> with such single liners as "Quote AC_COMPILE_IFELSE() input" or "Trivial
> whitespace changes and reordering", *REALLY*?

There are lots of big advantages to having small, independent patches
for independent problems / improvements.

I agree it doesn't make much sense to spend lots of time on pulling
apart bigger patches; but if you can make them as small commits
_in the first place_, it is _less work in total_ even.

And, in this case, I know for a fact that some of those were created
as these three-liners (I suggested one of-em, the quoting thing --
newer autoconf complains without it).


Segher