[Libsysio-commit] HEAD: libsysio/drivers/incore fs_incore.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/drivers/incore
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16325/drivers/incore

Modified Files:
	fs_incore.c 
Log Message:


+ Merged in changes from namespace_assembly branch (see .../misc/init-env.sh)
	This provoked a bunch of bugs. See below.

+ Fixed a bug in _sysio_enumerate_extents(). If the IO operation was
	short, it would go round the loop again, mistakenly trying
	to fill more of the extent.
+ In rw.c, fixed bugs in [p]{read,write}[vx] (all the synchronous routines)
	that improperly propagated error returns. They were returning -errno
	instead of setting errno and returning -1.
+ In fs_native.c:doiov, fixed a bug where a zero-length IO was improperly
	thought to be an error.
+ In lseek.c:_sysio_lseek, fixed final position check to properly determine
	{under,over}flow.
+ In link.c:link, fixed the existence check. No error is returned for
	nonexistent files when ND_NEGOK is specified. We're supposed
	to check whether it's a negative entry or not.
+ A new macro, I_GONE, was added to inode.h. This will *try* to
	kill an inode but if it can't, it becomes a zombie instead.
+ In unlink.c:unlink, link.c:link, rename.c:rename, the driver ops
	were being called but the actual operation in the internal path
	tree was not reflected. Also, for unlink and rename, use the
	new I_GONE macro on the destroyed inode.
+ In fs_native.c:native_inop_gone, close() was always called, even when
	the fildes was -1.
+ In fs_native.c:native_inop_gone, close() was called. We really meant
	to call syscal(SYS_close, ...);
+ In namei.c:_sysio_path_walk, fixed broken symlink handling. It wasn't
	following symlinks anywhere if ND_NOFOLLOW was set. That flag only
	means that the *last* component should not be followed.
+ In namei.c:_sysio_path_walk, fixed buffer overrun problem for very long
	symlinks.
+ In fs_incore.c, fixed dirop_{link,rename,unlink,rmdir} because they
	were manipulating the system path cache and shouldn't.
+ In mount.c:_sysio_unmount_all we were mistakenly releasing an FS root
	after a failed unmount attempt.
+ Fixes in test_regions.c free allocated memory at the end so valgrind
	doesn't show a leak.


Index: fs_incore.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/drivers/incore/fs_incore.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -w -b -B -p -r1.13 -r1.14
--- fs_incore.c	6 Feb 2004 20:07:29 -0000	1.13
+++ fs_incore.c	14 Feb 2004 19:42:57 -0000	1.14
@@ -1262,17 +1262,7 @@ _sysio_incore_dirop_rmdir(struct pnode *
 	err =
 	    incore_unlink_entry(I2IC(pno->p_parent->p_base->pb_ino),
 				&pno->p_base->pb_name);
-	if (err)
 		return err;
-	I_RELE(ino);
-
-	/*
-	 * Adjust link count.
-	 */
-	assert(icino->ici_st.st_nlink > 2);
-	icino->ici_st.st_nlink--;
-
-	return 0;
 }
 
 static int
@@ -1417,9 +1407,6 @@ _sysio_incore_dirop_rename(struct pnode 
 					&new->p_base->pb_name);
 		if (err)
 			return err;
-		I_RELE(new->p_base->pb_ino);
-		_sysio_i_gone(new->p_base->pb_ino);
-		new->p_base->pb_ino = NULL;
 	}
 
 	/*
@@ -1468,11 +1455,7 @@ _sysio_incore_dirop_unlink(struct pnode 
 	err =
 	    incore_unlink_entry(I2IC(pno->p_parent->p_base->pb_ino),
 				&pno->p_base->pb_name);
-	if (err)
 		return err;
-	I_RELE(ino);
-
-	return 0;
 }
 
 static int