libsysio-commit

[Libsysio-commit] HEAD: libsysio/src mknod.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6276

Modified Files:
	mknod.c 
Log Message:


Fixed comment; We support FIFO type now too.

Fixed test for type; Use the S_IS macros instead of a direct test for the
mode bits.

Fixed return value for unsupported types. Was EPERM, now EINVAL.


Index: mknod.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/mknod.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -w -b -B -p -r1.8 -r1.9
--- mknod.c	31 Mar 2004 17:43:18 -0000	1.8
+++ mknod.c	14 Apr 2004 16:25:40 -0000	1.9
@@ -79,11 +79,10 @@ __xmknod(int __ver, const char *path, mo
 	}
 
 	/*
-	 * Support only character-special right now.
+	 * Support only character-special and fifos right now.
 	 */
-	if (((mode & S_IFMT) != S_IFIFO) &&
-	    ((mode & S_IFMT) != S_IFCHR)) {
-		err = -EPERM;
+	if (!(S_ISDIR(mode) || S_ISFIFO(mode))) {
+		err = -EINVAL;
 		goto out;
 	}
 

[Libsysio-commit] HEAD: libsysio/src mknod.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26550

Modified Files:
	mknod.c 
Log Message:


Last change screwed up in the change. We went from checking to see
that the node was either CHR or FIFO, to DIR or FIFO. Oops! This rev
makes it CHR again.


Index: mknod.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/mknod.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -w -b -B -p -r1.9 -r1.10
--- mknod.c	14 Apr 2004 16:25:40 -0000	1.9
+++ mknod.c	19 Apr 2004 19:54:25 -0000	1.10
@@ -81,7 +81,7 @@ __xmknod(int __ver, const char *path, mo
 	/*
 	 * Support only character-special and fifos right now.
 	 */
-	if (!(S_ISDIR(mode) || S_ISFIFO(mode))) {
+	if (!(S_ISCHR(mode) || S_ISFIFO(mode))) {
 		err = -EINVAL;
 		goto out;
 	}

[Libsysio-commit] HEAD: libsysio/src mknod.c

[Ruth K. <rk...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25585

Modified Files:
	mknod.c 
Log Message:
fix compile warning, from Kevin Pedretti

Index: mknod.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/mknod.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -w -b -B -p -r1.15 -r1.16
--- mknod.c	27 Jul 2004 15:00:48 -0000	1.15
+++ mknod.c	29 Sep 2004 15:30:20 -0000	1.16
@@ -62,10 +62,6 @@
 #undef mknod
 #undef __xmknod
 
-#if defined(BSD) || defined(REDSTORM)
-#define _MKNOD_VER	0
-#endif
-
 int
 PREPEND(__, SYSIO_INTERFACE_NAME(xmknod))(int __ver, 
 					  const char *path, 

[Libsysio-commit] HEAD: libsysio/src mknod.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory sc8-pr-cvs6.sourceforge.net:/tmp/cvs-serv14335

Modified Files:
	mknod.c 
Log Message:


Modified to remove dependency on _BSD_SOURCE definition.


Index: mknod.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/mknod.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -w -b -B -p -r1.18 -r1.19
--- mknod.c	3 May 2006 22:31:04 -0000	1.18
+++ mknod.c	12 Apr 2007 20:07:02 -0000	1.19
@@ -41,10 +41,6 @@
  * le...@sa...
  */
 
-#if defined(__linux__)
-#define _BSD_SOURCE
-#endif
-
 #include <unistd.h>
 #include <errno.h>
 #include <assert.h>
@@ -76,8 +72,7 @@ _sysio_mknod(struct pnode *pno, mode_t m
 	 * Support only regular, character-special and fifos right now.
 	 * (mode & S_IFMT) == 0 is the same as S_IFREG.
 	 */
-	if ((mode & S_IFMT) &&
-	    !(S_ISREG(mode) || S_ISCHR(mode) || S_ISFIFO(mode)))
+	if (!(S_ISREG(mode) || S_ISCHR(mode) || S_ISFIFO(mode)))
 		return -EINVAL;
 
 	if (IS_RDONLY(pno))

[Libsysio-commit] HEAD: libsysio/src mknod.c

[Lee W. <lw...@us...>]

Update of /cvsroot/libsysio/libsysio/src
In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv29582

Modified Files:
	mknod.c 
Log Message:


Removed unused error label.


Index: mknod.c
===================================================================
RCS file: /cvsroot/libsysio/libsysio/src/mknod.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -w -b -B -p -r1.24 -r1.25
--- mknod.c	4 Aug 2009 15:01:24 -0000	1.24
+++ mknod.c	17 Aug 2009 17:45:45 -0000	1.25
@@ -116,7 +116,6 @@ PREPEND(__, SYSIO_INTERFACE_NAME(xmknod)
 		goto out;
 
 	err = _sysio_mknod(pno, mode, *dev);
-error:
 	P_PUT(pno->p_parent);
 	P_PUT(pno);
 out: